diff mbox series

[xfrm-next] xfrm6: remove BUG_ON from xfrm6_dst_ifdown

Message ID 1542014902-11354-1-git-send-email-lirongqing@baidu.com
State Awaiting Upstream, archived
Delegated to: David Miller
Headers show
Series [xfrm-next] xfrm6: remove BUG_ON from xfrm6_dst_ifdown | expand

Commit Message

Li RongQing Nov. 12, 2018, 9:28 a.m. UTC
if loopback_idev is NULL pointer, and the following access of
loopback_idev will trigger panic, which is same as BUG_ON

Signed-off-by: Li RongQing <lirongqing@baidu.com>
---
 net/ipv6/xfrm6_policy.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Steffen Klassert Nov. 23, 2018, 7:53 a.m. UTC | #1
On Mon, Nov 12, 2018 at 05:28:22PM +0800, Li RongQing wrote:
> if loopback_idev is NULL pointer, and the following access of
> loopback_idev will trigger panic, which is same as BUG_ON
> 
> Signed-off-by: Li RongQing <lirongqing@baidu.com>

Patch applied, thanks!
diff mbox series

Patch

diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c
index d35bcf92969c..769f8f78d3b8 100644
--- a/net/ipv6/xfrm6_policy.c
+++ b/net/ipv6/xfrm6_policy.c
@@ -262,7 +262,6 @@  static void xfrm6_dst_ifdown(struct dst_entry *dst, struct net_device *dev,
 	if (xdst->u.rt6.rt6i_idev->dev == dev) {
 		struct inet6_dev *loopback_idev =
 			in6_dev_get(dev_net(dev)->loopback_dev);
-		BUG_ON(!loopback_idev);
 
 		do {
 			in6_dev_put(xdst->u.rt6.rt6i_idev);