| Message ID | 1530675153-8748-1-git-send-email-kakuma@valinux.co.jp |
|---|---|
| State | Accepted, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
| Series | [iproute2] tc: Fix the bug not to display prio and quantum options of htb | expand |
On Tue, Jul 3, 2018 at 8:33 PM fumihiko kakuma <kakuma@valinux.co.jp> wrote: > > A commandline like 'tc -d class show dev dev-name' does not > display value of prio and quantum option when we use htb qdisc. > This patch fixes the bug. > > Signed-off-by: Fumihiko Kakuma <kakuma@valinux.co.jp> Good catch! Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
On Wed, 4 Jul 2018 12:32:33 +0900 fumihiko kakuma <kakuma@valinux.co.jp> wrote: > A commandline like 'tc -d class show dev dev-name' does not > display value of prio and quantum option when we use htb qdisc. > This patch fixes the bug. > > Signed-off-by: Fumihiko Kakuma <kakuma@valinux.co.jp> Applied
diff --git a/tc/q_htb.c b/tc/q_htb.c index 7d5f6ce..b93d31d 100644 --- a/tc/q_htb.c +++ b/tc/q_htb.c @@ -291,9 +291,9 @@ static int htb_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt) if (RTA_PAYLOAD(tb[TCA_HTB_PARMS]) < sizeof(*hopt)) return -1; if (!hopt->level) { - print_int(PRINT_ANY, "prio", "prio ", (int)hopt->prio); + print_int(PRINT_ANY, "prio", "prio %d ", (int)hopt->prio); if (show_details) - print_int(PRINT_ANY, "quantum", "quantum ", + print_int(PRINT_ANY, "quantum", "quantum %d ", (int)hopt->quantum); }
A commandline like 'tc -d class show dev dev-name' does not display value of prio and quantum option when we use htb qdisc. This patch fixes the bug. Signed-off-by: Fumihiko Kakuma <kakuma@valinux.co.jp> --- tc/q_htb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)