diff mbox series

[net] r8152: fix tx packets accounting

Message ID 1519614730.3258.7.camel@gmail.com
State Accepted, archived
Delegated to: David Miller
Headers show
Series [net] r8152: fix tx packets accounting | expand

Commit Message

Eric Dumazet Feb. 26, 2018, 3:12 a.m. UTC 
From: Eric Dumazet <edumazet@google.com>

r8152 driver handles TSO packets (limited to ~16KB) quite well,
but pretends each TSO logical packet is a single packet on the wire.

There is also some error since headers are accounted once, but
error rate is small enough that we do not care.

Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 drivers/net/usb/r8152.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller Feb. 27, 2018, 2:02 a.m. UTC | #1 
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 25 Feb 2018 19:12:10 -0800

> From: Eric Dumazet <edumazet@google.com>
> 
> r8152 driver handles TSO packets (limited to ~16KB) quite well,
> but pretends each TSO logical packet is a single packet on the wire.
> 
> There is also some error since headers are accounted once, but
> error rate is small enough that we do not care.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Applied, thanks Eric.
diff mbox series

Patch

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 958b2e8b90f689249abfea6c713e491300a7dc94..86f7196f9d91fbf55c791fff88687a43518d66d8 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -1794,7 +1794,7 @@  static int r8152_tx_agg_fill(struct r8152 *tp, struct tx_agg *agg)
 
 		tx_data += len;
 		agg->skb_len += len;
-		agg->skb_num++;
+		agg->skb_num += skb_shinfo(skb)->gso_segs ?: 1;
 
 		dev_kfree_skb_any(skb);