From patchwork Sun Jan 7 18:36:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Subash Abhinov Kasiviswanathan X-Patchwork-Id: 856588 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=codeaurora.org header.i=@codeaurora.org header.b="YHdSIbMu"; dkim=pass (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="YHdSIbMu"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zF6b202BZz9s7f for ; Mon, 8 Jan 2018 05:37:33 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754507AbeAGShE (ORCPT ); Sun, 7 Jan 2018 13:37:04 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:46282 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754470AbeAGShD (ORCPT ); Sun, 7 Jan 2018 13:37:03 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B9E20602B9; Sun, 7 Jan 2018 18:37:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1515350222; bh=9XsXD72gTo9vpEm1wjRwOyx+Vdo5SLGyuLJq4z9Slss=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YHdSIbMuBeuO2We4Sj9tf+wPL6pwIvYkMSVq/tn8swC9hZ9wZRhcF5/s2ST61IOOo XR48eo1cyurvNeU9ycCw37NBkItcQ8NJTeNpYumxqnDXpIsi9G1/6agz4nUOVUZ7dk 5svZ1MKpQVqLekobQziHXWXLrowASlzGmXKtswgA= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from subashab-lnx.qualcomm.com (unknown [129.46.15.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: subashab@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id AABAB602B9; Sun, 7 Jan 2018 18:37:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1515350222; bh=9XsXD72gTo9vpEm1wjRwOyx+Vdo5SLGyuLJq4z9Slss=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YHdSIbMuBeuO2We4Sj9tf+wPL6pwIvYkMSVq/tn8swC9hZ9wZRhcF5/s2ST61IOOo XR48eo1cyurvNeU9ycCw37NBkItcQ8NJTeNpYumxqnDXpIsi9G1/6agz4nUOVUZ7dk 5svZ1MKpQVqLekobQziHXWXLrowASlzGmXKtswgA= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AABAB602B9 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=subashab@codeaurora.org From: Subash Abhinov Kasiviswanathan To: davem@davemloft.net, netdev@vger.kernel.org, lkp@intel.com, edumazet@google.com Cc: Subash Abhinov Kasiviswanathan Subject: [PATCH net-next v3 RESEND 05/10] net: qualcomm: rmnet: Set pacing shift Date: Sun, 7 Jan 2018 11:36:35 -0700 Message-Id: <1515350200-29472-6-git-send-email-subashab@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1515350200-29472-1-git-send-email-subashab@codeaurora.org> References: <1515350200-29472-1-git-send-email-subashab@codeaurora.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The real device over which the rmnet devices are installed also aggregate multiple IP packets and sends them as a single large aggregate frame to the hardware. This causes degraded throughput for TCP TX due to bufferbloat. To overcome this problem, pacing shift value of 8 is set using the sk_pacing_shift_update() helper. This value was determined based on experiments with a single stream TCP TX using iperf for a duration of 30s. Pacing shift | Observed data rate (Mbps) 10 | 9 9 | 140 8 | 146 (Max link rate) Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c index 8e1f43a..8f8c4f2 100644 --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c @@ -16,6 +16,7 @@ #include #include #include +#include #include "rmnet_private.h" #include "rmnet_config.h" #include "rmnet_vnd.h" @@ -204,6 +205,8 @@ void rmnet_egress_handler(struct sk_buff *skb) struct rmnet_priv *priv; u8 mux_id; + sk_pacing_shift_update(skb->sk, 8); + orig_dev = skb->dev; priv = netdev_priv(orig_dev); skb->dev = priv->real_dev;