| Message ID | 1509167146-93171-1-git-send-email-weiyongjun1@huawei.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: bcmgenet: Avoid calling platform_device_put() twice in bcmgenet_mii_exit() | expand |
On 10/27/2017 10:05 PM, Wei Yongjun wrote: > Remove platform_device_put() call after platform_device_unregister() > from function bcmgenet_mii_exit(), otherwise, we will call > platform_device_put() twice. > > Fixes: 9a4e79697009 ("net: bcmgenet: utilize generic Broadcom UniMAC > MDIO controller driver") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/net/ethernet/broadcom/genet/bcmmii.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c > index ba3fcfd..5333274 100644 > --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c > +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c > @@ -571,5 +571,4 @@ void bcmgenet_mii_exit(struct net_device *dev) > of_phy_deregister_fixed_link(dn); > of_node_put(priv->phy_dn); > platform_device_unregister(priv->mii_pdev); > - platform_device_put(priv->mii_pdev); > } > Acked-by: Doug Berger <opendmb@gmail.com>
On 10/27/2017 10:05 PM, Wei Yongjun wrote: > Remove platform_device_put() call after platform_device_unregister() > from function bcmgenet_mii_exit(), otherwise, we will call > platform_device_put() twice. > > Fixes: 9a4e79697009 ("net: bcmgenet: utilize generic Broadcom UniMAC > MDIO controller driver") Please don't force a wrap to 80 columns for commit subjects. > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com> > --- > drivers/net/ethernet/broadcom/genet/bcmmii.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c > index ba3fcfd..5333274 100644 > --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c > +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c > @@ -571,5 +571,4 @@ void bcmgenet_mii_exit(struct net_device *dev) > of_phy_deregister_fixed_link(dn); > of_node_put(priv->phy_dn); > platform_device_unregister(priv->mii_pdev); > - platform_device_put(priv->mii_pdev); > } >
From: Wei Yongjun <weiyongjun1@huawei.com> Date: Sat, 28 Oct 2017 05:05:46 +0000 > Remove platform_device_put() call after platform_device_unregister() > from function bcmgenet_mii_exit(), otherwise, we will call > platform_device_put() twice. > > Fixes: 9a4e79697009 ("net: bcmgenet: utilize generic Broadcom UniMAC > MDIO controller driver") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Applied, thank you.
diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c index ba3fcfd..5333274 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c @@ -571,5 +571,4 @@ void bcmgenet_mii_exit(struct net_device *dev) of_phy_deregister_fixed_link(dn); of_node_put(priv->phy_dn); platform_device_unregister(priv->mii_pdev); - platform_device_put(priv->mii_pdev); }
Remove platform_device_put() call after platform_device_unregister() from function bcmgenet_mii_exit(), otherwise, we will call platform_device_put() twice. Fixes: 9a4e79697009 ("net: bcmgenet: utilize generic Broadcom UniMAC MDIO controller driver") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/net/ethernet/broadcom/genet/bcmmii.c | 1 - 1 file changed, 1 deletion(-)