| Message ID | 1496913493-23293-3-git-send-email-nicolas.dichtel@6wind.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, Jun 08, 2017 at 11:18:13AM +0200, Nicolas Dichtel wrote: > Each time a new speed is added, the bonding 802.3ad isn't updated. Add a > comment to remind the developer to update this driver. > > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> Acked-by: Andy Gospodarek <andy@greyhouse.net> > --- > include/uapi/linux/ethtool.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h > index d179d7767f51..7d4a594d5d58 100644 > --- a/include/uapi/linux/ethtool.h > +++ b/include/uapi/linux/ethtool.h > @@ -1486,8 +1486,10 @@ enum ethtool_link_mode_bit_indices { > * it was forced up into this mode or autonegotiated. > */ > > -/* The forced speed, in units of 1Mb. All values 0 to INT_MAX are legal. */ > -/* Update drivers/net/phy/phy.c:phy_speed_to_str() when adding new values */ > +/* The forced speed, in units of 1Mb. All values 0 to INT_MAX are legal. > + * Update drivers/net/phy/phy.c:phy_speed_to_str() and > + * drivers/net/bonding/bond_3ad.c:__get_link_speed() when adding new values. A little wide, but not wider than it was before, so that's fine with me. > + */ > #define SPEED_10 10 > #define SPEED_100 100 > #define SPEED_1000 1000 > -- > 2.8.1 >
From: Nicolas Dichtel <nicolas.dichtel@6wind.com> Date: Thu, 8 Jun 2017 11:18:13 +0200 > Each time a new speed is added, the bonding 802.3ad isn't updated. Add a > comment to remind the developer to update this driver. > > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> Applied.
diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h index d179d7767f51..7d4a594d5d58 100644 --- a/include/uapi/linux/ethtool.h +++ b/include/uapi/linux/ethtool.h @@ -1486,8 +1486,10 @@ enum ethtool_link_mode_bit_indices { * it was forced up into this mode or autonegotiated. */ -/* The forced speed, in units of 1Mb. All values 0 to INT_MAX are legal. */ -/* Update drivers/net/phy/phy.c:phy_speed_to_str() when adding new values */ +/* The forced speed, in units of 1Mb. All values 0 to INT_MAX are legal. + * Update drivers/net/phy/phy.c:phy_speed_to_str() and + * drivers/net/bonding/bond_3ad.c:__get_link_speed() when adding new values. + */ #define SPEED_10 10 #define SPEED_100 100 #define SPEED_1000 1000
Each time a new speed is added, the bonding 802.3ad isn't updated. Add a comment to remind the developer to update this driver. Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> --- include/uapi/linux/ethtool.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)