From patchwork Thu Feb 2 02:13:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 722728 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vDNp82qKbz9s75 for ; Thu, 2 Feb 2017 13:13:36 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ucZuXMyt"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751082AbdBBCN1 (ORCPT ); Wed, 1 Feb 2017 21:13:27 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:34079 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073AbdBBCNZ (ORCPT ); Wed, 1 Feb 2017 21:13:25 -0500 Received: by mail-pf0-f193.google.com with SMTP id y143so241119pfb.1 for ; Wed, 01 Feb 2017 18:13:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=fs5VhOzCj/B+Ctco+gw4uy9BwgSO6OW14s0c6ZSP1Uo=; b=ucZuXMytDbR/q3L2mv0ntMLl7xZEVkIYAHChpQVYdkI+PJOzo6eje/WTqL5j56xVkM vqzkFAEdGQd+yNNXBFliNso0R79+CsgId3rHoOav+QGshj3DtI5+cghc4z4/7UIhMsDd 4i6351ruSqJnwREz2udmgQmmash6LkymOCTBGD+Z9BRX21UqaGgmS9W6T69dQJFb/NsN fd21nscokpM9QbwqMIEWt4mZn9fXAJcPWDp0as5BHtO86DrI63FxEEB3JbxebBo3O3IR RByGPIs8zoPuvcVNYyaiiLuQ/ZpxpLr7+XxHcILDAT2LbmXyWp8T2S1d8TSpqmL5uvN4 mP0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=fs5VhOzCj/B+Ctco+gw4uy9BwgSO6OW14s0c6ZSP1Uo=; b=npRwtAAZap8NDUb1ox5fooUsIty95toQUVfL2krmsLiYjRvAQ3yl+dZ6+2UPKD8d1d 6eoqBVQem+q7ef+Y4QUu9Jg4Nf6SK6t/n4s26SCThxK+3KtALJ2gL9q1GqeO4eEZvCBQ nBKU2hINXKQfQHBm455iV8rlZ2GQt94MTbAyR50QvAonkiUBOq4D6+61Bw6ryfN3/kOc FmhHwI/nUlSlFuvUQ19gDRAcPXCBRNs7S3UkIIwEigKZPiXpmcvKM/2vRpPqf1eLVsQH i5S2oU6bx2GR9zkVe7MNmpSrZyzz4DIzOiBBTOkgiABFTOHaaYP7XaNgpkAjsuoH8D0N ecAg== X-Gm-Message-State: AIkVDXLqb/x98cyTV1siw5KywB8hgaPPmCfaDPI8xsN+Amz/9GHOKMfjggHsc6huXLhCfA== X-Received: by 10.99.241.83 with SMTP id o19mr7541622pgk.195.1486001605216; Wed, 01 Feb 2017 18:13:25 -0800 (PST) Received: from [172.29.160.201] ([172.29.160.201]) by smtp.googlemail.com with ESMTPSA id s26sm53397493pge.33.2017.02.01.18.13.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Feb 2017 18:13:24 -0800 (PST) Message-ID: <1486001603.13103.10.camel@edumazet-glaptop3.roam.corp.google.com> Subject: [PATCH net-next] net: remove useless pfmemalloc setting From: Eric Dumazet To: Josef Bacik , "David S . Miller" Cc: netdev@vger.kernel.org Date: Wed, 01 Feb 2017 18:13:23 -0800 In-Reply-To: <1485993427.6360.170.camel@edumazet-glaptop3.roam.corp.google.com> References: <1485983078-2372-1-git-send-email-jbacik@fb.com> <1485992285.6360.168.camel@edumazet-glaptop3.roam.corp.google.com> <1485993427.6360.170.camel@edumazet-glaptop3.roam.corp.google.com> X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eric Dumazet When __alloc_skb() allocates an skb from fast clone cache, setting pfmemalloc on the clone is not needed. Clone will be properly initialized later at skb_clone() time, including pfmemalloc field, as it is included in the headers_start/headers_end section which is fully copied. Signed-off-by: Eric Dumazet --- net/core/skbuff.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 26c1344cc23e31d4248d23fc007bcab4b034c5c9..4f8f2a1a66b5a36705e8f9966f7abd751932dcc6 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -271,7 +271,6 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t gfp_mask, atomic_set(&fclones->fclone_ref, 1); fclones->skb2.fclone = SKB_FCLONE_CLONE; - fclones->skb2.pfmemalloc = pfmemalloc; } out: return skb;