Message ID | 1474301694-13477-1-git-send-email-nicolas.dichtel@6wind.com |
---|---|
State | Awaiting Upstream, archived |
Delegated to: | David Miller |
Headers | show |
Le 19/09/2016 à 18:14, Nicolas Dichtel a écrit : > From: Huaibin Wang <huaibin.wang@6wind.com> > > Order of arguments is wrong. > The wrong code has been introduced by commit 7d4f8d871ab1, but is compiled > only since commit 9df70b66418e. > > Note that this may break netlink dumps. > > Fixes: 9df70b66418e ("i40e: Remove incorrect #ifdef's") > Fixes: 7d4f8d871ab1 ("switchdev; add VLAN support for port's bridge_getlink") > CC: Scott Feldman <sfeldma@gmail.com> > CC: Carolyn Wyborny <carolyn.wyborny@intel.com> > CC: Catherine Sullivan <catherine.sullivan@intel.com> > Signed-off-by: Huaibin Wang <huaibin.wang@6wind.com> > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> Hi Jeff, any news about this patch? David has marked it "awaiting upstream" on the patchwork, so I understand it should go to your tree. Thank you, Nicolas
On Fri, 2016-09-23 at 11:12 +0200, Nicolas Dichtel wrote: > Le 19/09/2016 à 18:14, Nicolas Dichtel a écrit : > > From: Huaibin Wang <huaibin.wang@6wind.com> > > > > Order of arguments is wrong. > > The wrong code has been introduced by commit 7d4f8d871ab1, but is > compiled > > only since commit 9df70b66418e. > > > > Note that this may break netlink dumps. > > > > Fixes: 9df70b66418e ("i40e: Remove incorrect #ifdef's") > > Fixes: 7d4f8d871ab1 ("switchdev; add VLAN support for port's > bridge_getlink") > > CC: Scott Feldman <sfeldma@gmail.com> > > CC: Carolyn Wyborny <carolyn.wyborny@intel.com> > > CC: Catherine Sullivan <catherine.sullivan@intel.com> > > Signed-off-by: Huaibin Wang <huaibin.wang@6wind.com> > > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> > Hi Jeff, > > any news about this patch? David has marked it "awaiting upstream" on the > patchwork, so I understand it should go to your tree. Yes, it needs to go through my tree. Please send it to intel-wired-lan@li sts.osuosl.org mailing list, that way I can track it through our patchwork projects. Also you can trim Scott Feldman and Catherine Sullivan from the CC list. http://patchwork.ozlabs.org/project/intel-wired-lan/list/
Le 23/09/2016 à 23:37, Jeff Kirsher a écrit : [snip] > Yes, it needs to go through my tree. Please send it to intel-wired-lan@li > sts.osuosl.org mailing list, that way I can track it through our patchwork Ok, will do. I didn't send it to this list the first time because this list is marked as "moderated for non-subscribers" in the MAINTAINERS file.
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index d0b3a1bb82ca..2843f6cae97a 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -9012,7 +9012,7 @@ static int i40e_ndo_bridge_getlink(struct sk_buff *skb, u32 pid, u32 seq, return 0; return ndo_dflt_bridge_getlink(skb, pid, seq, dev, veb->bridge_mode, - nlflags, 0, 0, filter_mask, NULL); + 0, 0, nlflags, filter_mask, NULL); } /* Hardware supports L4 tunnel length of 128B (=2^7) which includes