From patchwork Wed May 18 16:05:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 623651 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3r8zv849ypz9t44 for ; Thu, 19 May 2016 02:20:20 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753408AbcERQUS (ORCPT ); Wed, 18 May 2016 12:20:18 -0400 Received: from mail-by2on0091.outbound.protection.outlook.com ([207.46.100.91]:6048 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752603AbcERQUP (ORCPT ); Wed, 18 May 2016 12:20:15 -0400 Received: from BY2PR03CA073.namprd03.prod.outlook.com (10.141.249.46) by CY1PR0301MB0602.namprd03.prod.outlook.com (10.160.142.21) with Microsoft SMTP Server (TLS) id 15.1.497.12; Wed, 18 May 2016 16:05:35 +0000 Received: from BN1BFFO11FD008.protection.gbl (2a01:111:f400:7c10::1:153) by BY2PR03CA073.outlook.office365.com (2a01:111:e400:2c5d::46) with Microsoft SMTP Server (TLS) id 15.1.497.12 via Frontend Transport; Wed, 18 May 2016 16:05:35 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD008.mail.protection.outlook.com (10.58.144.71) with Microsoft SMTP Server (TLS) id 15.1.497.8 via Frontend Transport; Wed, 18 May 2016 16:05:34 +0000 Received: from fabio-Latitude-E6410.am.freescale.net (fabio-Latitude-E6410.am.freescale.net [10.29.244.169]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u4IG5VFL020979; Wed, 18 May 2016 09:05:31 -0700 From: Fabio Estevam To: CC: , , , , Fabio Estevam Subject: [PATCH] Revert "phy: add support for a reset-gpio specification" Date: Wed, 18 May 2016 13:05:00 -0300 Message-ID: <1463587500-12293-1-git-send-email-fabio.estevam@nxp.com> X-Mailer: git-send-email 1.9.1 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131080611344912384; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(9170700003)(85426001)(48376002)(586003)(50466002)(50986999)(110136002)(189998001)(77096005)(8676002)(8936002)(81166006)(11100500001)(6806005)(50226002)(1220700001)(5890100001)(4326007)(2906002)(5008740100001)(87936001)(33646002)(104016004)(105606002)(92566002)(86362001)(2351001)(229853001)(36756003)(106466001)(19580405001)(551934003)(47776003)(19580395003)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0301MB0602; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:sfv; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD008; 1:DWQCHoKDIF9+tl8+oUx+vW39nqKMjk8D/rDZ3Ii/T6WDiIqVKK2HtflSL93libsuGtUTrJeSaYssqgMD10Sm4024tBaqhq8d8q6WnW227YSmGKdjE0ixI3AtKPsMJgx0xbYOeob3bApwnw4iEhDB/Nbi5jKtpIyfRITwtAwSb2KwAkFIVveubQrk+gotCGNnAM8fOkpptDrcMSbUIKbp570Aqt05zF4q2H4qGNfcLXJGblwa/yl1dR4xMrpovFUwmD5LACQ0R2vkdHpjlVLciVQRKNvd8KqxHJnf9PqsdbTVoifwR1VA0nAM23hFw1IbmF15Hk8upsLuV28o8RTA2G/AmcDGdH8WHBVr1k65LinTUjoX+jTgr57oYNiphYLMg/Gx6PJ78K8S27paFB6ASYLtXaKr8B15KRuabESxyB9AI2Y1MAB1+PerS2iik08AKsUn2AKkLkRvfsJATAuZcjsYP92r64CVVpEJIgfGyl0mTuysU4bdApXFgYlgorrEsTd5K4rHY6hoB+2/t3LfQEMjuw/yWlGIioY0iJTx4Rqmt2T7Suxa+CCXbffZSkam8zXaaNao43e5wHgq5BcAF5u6dCrtHX/jBajrZUtTgCalw18gHIxanvvQ8x+YcJ8MN161ZuSI6KKYwRFTzR9ctjUeuOB9gXtJHdVtXj581zE= MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: e20cdb18-abac-4a62-2ea3-08d37f363e9c X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0602; 2:0JJuPblrnI5eyxnxq6YbxgwUJ7vQnmIagrj4cRfW5F+mikiUohLd+nwzQd6W8C9B7g461Bsv6XnpIb1WSaUTinBikCux85UE2MSIwVTkuMHBxtVkIlymeNNRerZxfHqe3r4OgRkJy3Hgho7Bt4VhQIAehfx9GqQ2aJU1yohpHemGfmQGbPx/Ty9GDzTbnJCY; 3:FK3RzcMoOv6Io3DuTPwhUVuVBodtE4b7YlFzbtB+UfMWhR/IHkzq/2PTEJz76ylZKkNn1aMsFiSyf76DrPMGgJivKItFMNAKzzg+sLZ4UPdSUmMtCN7IrmJ/cH8vnsm6PblpYqVMGa5pOQdIVkfJ4ZhJx9RuoN37Anm537woDR9lKfWrC/2wwZaeBB0Kec7WeiIPBhC+k3W12zURU3VbS+3siK1qg8oCYUl2EKZsJ7E= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB0602; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0602; 25:zN/dR27UwuxCBkAuRltj5YWRc73ixNOaem8ZKC64uV3dpXESxmCsBrt0A9c5+Oo8muDgSbiqAWslP3qm+9DJAwf+T3Kxtzdq6m0zVY92ENhS9KgRM/wSwMc364l+X7ih8gj3248MqX0Xtq7OsAKwlBv3s2L7Hykn2qo6maU0PXKB1E37HBQuZAmQiLXAXPLQ7OIpuyBmoCXLRriyMVNeU1UDAfE1my/78mtflZHdl+5wSuNvB91th6EV31pmsQ9KV38tHAy/Z6vL49T7ai4YLSS5nJeMYJUJUNK3Ti90Wo7gj8/lxXfETj4hiiMLZH1iF0eT2+p909XviLcuKUDdkMU5gdizNLnjJoQsJI/yNGkrdC8JYUVQ2b/t9TrDTcZQiGifozo5TUEBTRQ6jgiROHH66uNLHK7GCU5/VgPvyQ6geRILbbVm1gBq8x2wq7UwnVFA0Jjh9QYBXGbnn5bv+EQ76RQgR6xNJ4zTw/IIYQm3NVGGGBbRQ1ils6ry6a43Vlb7OHIy2D8eWv5xdIIrx5J0jJVCPRKqwYrWleSO4Eq69OiCKpbZJnjzKrgdt9IOnyq4hDnn1RAAnMemMWpUuTyroDIO1e324a6pPy0j7uLh3JxcNEGq+QbeLApPbsLJffkvlNMpHS97ih+XgSIjGI8ME5GeMW+V6oajGY2KodlV25VNrcx9nhxRv60LRb8G9zlRamx/8y0puIRPRAVZva+eVbV/lQDHHJeKphOtiv0r52bprVr3D76J/ZqNH7YT/5roMk9EtM5T++zHNfAhhg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(13017025)(13015025)(8121501046)(13023025)(13024025)(13018025)(10201501046)(3002001)(6055026); SRVR:CY1PR0301MB0602; BCL:0; PCL:0; RULEID:(400006); SRVR:CY1PR0301MB0602; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0602; 4:XG4focVA4M7E63RNuhSYOlOHqnw5EqZYIG/SiwpJxnoTDO0wDIcNcqAAnncB4MbWbgdpCJsOicS2FbFPI+iXxnMlBoIft/j88GxIAAigAR+Gf0i5rmg1equievGHLHKrcM8fpxJgf2ey31lytzK+XoL4QpmQ3+bMQkSVcQ2OcQwWJq65EogAclCe5RuxDrnXUnvIJSDwwGhfEKXYHEGY5eKJhY1n/cQGz1Dfdj/9VD9SWpBdAW/k9T8so+gfc2Q92wlOUBVoIk5wdTgODimDfTn9XhELTf6SrZ1hKjDexKzg1tzcjLgZzHhgpwuTqqFq0chWGXalKhRoZVbuCAvVmKI97PgX5DN88IxHlhHd1AmTPxCcC+j5eb/WFyf6PXP2LP2fZfCjNbFKLVnrggSGBwNJRyBI6AYsZRsd1fItbE07qPMSepjv7OBoOZqCWy56iCzdU/sv9znyBtGEP8kBLe0gJbirNQD566BU1curBP8= X-Forefront-PRVS: 0946DC87A1 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0301MB0602; 23:dFSuzKaRGsgDJkhW7pmytwtOWzBqS6JKd6UQSMP?= =?us-ascii?Q?91EGmtfygkfqIiWnSvUiunU4dFQGVbOaDnTn6DxCGY3bwkRSzDyAOWhwvLVD?= =?us-ascii?Q?hTWFQMFZFTtCewoCFuBDnSh9FQvun7qYjhol46ArdOY8JfeAP5qEhZwadvy4?= =?us-ascii?Q?QJRLQh99XfWrUSxFQamoPL2vOPHYXCVH9a+7FrsjAl56IQU1toHzyTjbgb0+?= =?us-ascii?Q?CY+c4prvy6QshhxGfqZFtnle0By9PxzeN35qxogK4nyLvaii1ZYypCkKnxB1?= =?us-ascii?Q?U65ADQA0/qCxJx+d201UWjSkoVRvS35jAtpvLHtd7du3wk++Brw6OIJxE1UZ?= =?us-ascii?Q?lSsG5HA3lJugjrzZzPq6mBuwh+ju6MP55SRCZjslvq4Fe07r5P/Lx1KFNByi?= =?us-ascii?Q?N2J2c9OAv6VPhPo1hY1KGpbhQ+q5AG2KJ79u918vOOPEJcw+xIckNZBuKsCR?= =?us-ascii?Q?xjKv49V1cEQpBmQL0cAFLOAN9sm+kN8d4+BK+7vFjSW8IcYTlp/jZTtIXiG9?= =?us-ascii?Q?AE4kDRIE1O77TE3faV0AjhiSEpmtKT2uUPLUSXjVi9oYMWot6otd4cVBR1br?= =?us-ascii?Q?FVU+Gr6JCT6xVdC80PTxc7LzBX+2hTzu/ymc5jkOSB4IFa2LDlOiainUjT/n?= =?us-ascii?Q?ZsTrgkrPd5+AVRY0v0WSNKv/nbIVMW4vtUTirw7hbjhBtbBT221qoRwPK/CR?= =?us-ascii?Q?3guXkb21yT/5TNiNMPsuKeoeEwKXh0uK80kKi7Fk2yKV7aqNBAiQHjX28PbR?= =?us-ascii?Q?zVhKr3XvN3zgBELvAsNJA5N3ttcfY7jdmPzI9NPDdHRpVlfVp52e/edW/+Jx?= =?us-ascii?Q?PIECEpCtJ/yeaaMGXMuxoQS596d/eKt2ccjOrwj47DdJ5piEUZ3ruSyVTJda?= =?us-ascii?Q?EqYMgWplxWI3WmOPqPA9GJegz71gqwwagiNb+kYvTauzziCq1Cg5DHGwkdm0?= =?us-ascii?Q?wjDKrtVU0GRgwiwSY3AO1M7Mrj8mfVgIuyMiBshyrPSK1fDyVovV5EbYcl/o?= =?us-ascii?Q?6uNzjygZA38j0luv9ix5s9CtZYJokFuRZ7APRTIjZ3uyKIpmBIQ/w6Kfd8hz?= =?us-ascii?Q?AyrPDaiZGno4QeW6bRl5/fGqzurge?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB0602; 5:7kp6/u2e6eNKce3BAYjIJLa7usr+iIKmtwLQoucbysGIrsBCA3PqVaiSxyFyI36v+eCn0nPKYyBg7Ve3eTk/oguN85CTbaEytnjG8Oh9ePFsjwkgscKR/sPp72vI3tp1poNjrg0M/aYAzV6q3K9mqVw5oeGWXxnIZ7N8mJOOx0g=; 24:kJaOBtavDWvor/Mxxh2cYtkIO9XWxI4euFdFdvgY+Ti4IEKyMpvzszoqh1E1kiylhfkMJBwXAb7ukCCMnmQAjiOesLFaP9kjZ5f5gxEgTuQ=; 7:wrdWDPUq6nUpJQFVCygzg/FOQWWu/criEfhTHRQGP6vPe6ts41XN5zlr2hZlXhbifXRJ/kEOH8omKCbKdz7WnI48gBO4x8EvmyMHzu7wf8AkkrscrDp8rbqrFP+e53OT/I27CKyfZUBS+P0aiBxfbO/dAVfF7uGjq6olmFC/pfyIqc0YB5qgKRSZH5WflB5S SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2016 16:05:34.1636 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB0602 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Commit da47b4572056 ("phy: add support for a reset-gpio specification") causes the following xtensa qemu crash according to Guenter Roeck: [ 9.366256] libphy: ethoc-mdio: probed [ 9.367389] (null): could not attach to PHY [ 9.368555] (null): failed to probe MDIO bus [ 9.371540] Unable to handle kernel paging request at virtual address 0000001c [ 9.371540] pc = d0320926, ra = 903209d1 [ 9.375358] Oops: sig: 11 [#1] This reverts commit da47b4572056487fd7941c26f73b3e8815ff712a. Reported-by: Guenter Roeck Signed-off-by: Fabio Estevam Acked-by: Florian Fainelli Tested-by: Guenter Roeck --- Documentation/devicetree/bindings/net/phy.txt | 3 --- drivers/net/phy/phy_device.c | 8 -------- 2 files changed, 11 deletions(-) diff --git a/Documentation/devicetree/bindings/net/phy.txt b/Documentation/devicetree/bindings/net/phy.txt index c00a9a8..bc1c3c8 100644 --- a/Documentation/devicetree/bindings/net/phy.txt +++ b/Documentation/devicetree/bindings/net/phy.txt @@ -35,8 +35,6 @@ Optional Properties: - broken-turn-around: If set, indicates the PHY device does not correctly release the turn around line low at the end of a MDIO transaction. -- reset-gpios: Reference to a GPIO used to reset the phy. - Example: ethernet-phy@0 { @@ -44,5 +42,4 @@ ethernet-phy@0 { interrupt-parent = <40000>; interrupts = <35 1>; reg = <0>; - reset-gpios = <&gpio1 17 GPIO_ACTIVE_LOW>; }; diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 307f72a..e977ba9 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -34,7 +34,6 @@ #include #include #include -#include #include @@ -1571,16 +1570,9 @@ static int phy_probe(struct device *dev) struct device_driver *drv = phydev->mdio.dev.driver; struct phy_driver *phydrv = to_phy_driver(drv); int err = 0; - struct gpio_descs *reset_gpios; phydev->drv = phydrv; - /* take phy out of reset */ - reset_gpios = devm_gpiod_get_array_optional(dev, "reset", - GPIOD_OUT_LOW); - if (IS_ERR(reset_gpios)) - return PTR_ERR(reset_gpios); - /* Disable the interrupt if the PHY doesn't support it * but the interrupt is still a valid one */