| Message ID | 1456696781-32384-1-git-send-email-igal.liberman@freescale.com |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
On 02/29/2016 09:17 AM, igal.liberman@freescale.com wrote: > From: Igal Liberman <igal.liberman@freescale.com> > > Errata dTSEC-A003 was fixed in P4080 rev 3.0. > Prior revisions are not supported, so the workaround can be removed. > > Signed-off-by: Igal Liberman <igal.liberman@freescale.com> Since when do we not support p4080 rev 2? -Scott
> -----Original Message----- > From: Scott Wood [mailto:scott.wood@nxp.com] > Sent: Tuesday, March 01, 2016 1:31 AM > To: igal.liberman@freescale.com; netdev@vger.kernel.org > Cc: scottwood@freescale.com; madalin.bucur@freescale.com > Subject: Re: [PATCH] fsl/fman: remove dTSEC-A003 Errata workaround > > On 02/29/2016 09:17 AM, igal.liberman@freescale.com wrote: > > From: Igal Liberman <igal.liberman@freescale.com> > > > > Errata dTSEC-A003 was fixed in P4080 rev 3.0. > > Prior revisions are not supported, so the workaround can be removed. > > > > Signed-off-by: Igal Liberman <igal.liberman@freescale.com> > > Since when do we not support p4080 rev 2? > Hi Scott, According to the following link, only rev 3 part numbers are "Active". Rev 2 part numbers are either "Not recommended for New Design" or "No Longer Manufactured". http://www.nxp.com/products/microcontrollers-and-processors/power-architecture-processors/qoriq-power-architecture-processors/qoriq-p4080-p4040-p4081-multicore-communications-processors:P4080?fpsp=1&tab=Package_Quality_Tab In addition, P4080 rev 2 was removed in SDK 1.5 (2013). This can be seen here (requires registration): https://freescale.sdlproducts.com/LiveContent/web/pub.xql?c=t&action=home&pub=QorIQ_SDK_1.9&lang=en-US#addHistory=true&filename=GUID-21A68B1F-4CD4-4959-9175-406D8FCD9A7A.xml&docid=GUID-21A68B1F-4CD4-4959-9175-406D8FCD9A7A&inner_id=&tid=&query=&scope=&resource=&toc=false&eventType=lcContent.loadDocGUID-21A68B1F-4CD4-4959-9175-406D8FCD9A7A Click on "Supported Targets" and scroll down to P4080. Igal > -Scott
On 03/02/2016 10:15 AM, Igal Liberman wrote: >> -----Original Message----- >> From: Scott Wood [mailto:scott.wood@nxp.com] >> Sent: Tuesday, March 01, 2016 1:31 AM >> To: igal.liberman@freescale.com; netdev@vger.kernel.org >> Cc: scottwood@freescale.com; madalin.bucur@freescale.com >> Subject: Re: [PATCH] fsl/fman: remove dTSEC-A003 Errata workaround >> >> On 02/29/2016 09:17 AM, igal.liberman@freescale.com wrote: >>> From: Igal Liberman <igal.liberman@freescale.com> >>> >>> Errata dTSEC-A003 was fixed in P4080 rev 3.0. >>> Prior revisions are not supported, so the workaround can be removed. >>> >>> Signed-off-by: Igal Liberman <igal.liberman@freescale.com> >> >> Since when do we not support p4080 rev 2? >> > > Hi Scott, > According to the following link, only rev 3 part numbers are "Active". Rev 2 part numbers are either "Not recommended for New Design" or "No Longer Manufactured". That doesn't mean we deliberately break them on newer kernels. > In addition, > P4080 rev 2 was removed in SDK 1.5 (2013). This can be seen here (requires registration): > https://freescale.sdlproducts.com/LiveContent/web/pub.xql?c=t&action=home&pub=QorIQ_SDK_1.9&lang=en-US#addHistory=true&filename=GUID-21A68B1F-4CD4-4959-9175-406D8FCD9A7A.xml&docid=GUID-21A68B1F-4CD4-4959-9175-406D8FCD9A7A&inner_id=&tid=&query=&scope=&resource=&toc=false&eventType=lcContent.loadDocGUID-21A68B1F-4CD4-4959-9175-406D8FCD9A7A > Click on "Supported Targets" and scroll down to P4080. This isn't the SDK. The SDK has been aggressively dropping support for older chips. -Scott
From: Scott Wood <scott.wood@nxp.com> Date: Mon, 29 Feb 2016 23:30:59 +0000 > On 02/29/2016 09:17 AM, igal.liberman@freescale.com wrote: >> From: Igal Liberman <igal.liberman@freescale.com> >> >> Errata dTSEC-A003 was fixed in P4080 rev 3.0. >> Prior revisions are not supported, so the workaround can be removed. >> >> Signed-off-by: Igal Liberman <igal.liberman@freescale.com> > > Since when do we not support p4080 rev 2? Yeah, this is rediculous. I'm not applying this patch, sorry.
diff --git a/drivers/net/ethernet/freescale/fman/fman_dtsec.c b/drivers/net/ethernet/freescale/fman/fman_dtsec.c index 7c92eb8..09dd46d 100644 --- a/drivers/net/ethernet/freescale/fman/fman_dtsec.c +++ b/drivers/net/ethernet/freescale/fman/fman_dtsec.c @@ -932,14 +932,6 @@ int dtsec_set_tx_pause_frames(struct fman_mac *dtsec, if (!is_init_done(dtsec->dtsec_drv_param)) return -EINVAL; - /* FM_BAD_TX_TS_IN_B_2_B_ERRATA_DTSEC_A003 Errata workaround */ - if (dtsec->fm_rev_info.major == 2) - if (pause_time <= 320) { - pr_warn("pause-time: %d illegal.Should be > 320\n", - pause_time); - return -EINVAL; - } - if (pause_time) { ptv = ioread32be(®s->ptv); ptv &= PTV_PTE_MASK;