From patchwork Fri Aug 14 02:56:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhang Shengju X-Patchwork-Id: 507253 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 657FB14018C for ; Fri, 14 Aug 2015 12:54:25 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754821AbbHNCyV (ORCPT ); Thu, 13 Aug 2015 22:54:21 -0400 Received: from cmccmta3.chinamobile.com ([221.176.66.81]:9811 "EHLO cmccmta3.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754797AbbHNCyU (ORCPT ); Thu, 13 Aug 2015 22:54:20 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.17]) by rmmx-syy-dmz-app09-12009 (RichMail) with SMTP id 2ee955cd5832755-1f76c; Fri, 14 Aug 2015 10:53:38 +0800 (CST) X-RM-TRANSID: 2ee955cd5832755-1f76c X-RM-SPAM-FLAG: 00000000 Received: from zhangshenju.host.bclinux.novalocal.openstacklocal (unknown[223.105.0.130]) by rmsmtp-syy-appsvr09-12009 (RichMail) with SMTP id 2ee955cd582b9dc-3b035; Fri, 14 Aug 2015 10:53:38 +0800 (CST) X-RM-TRANSID: 2ee955cd582b9dc-3b035 From: Zhang Shengju To: netdev@vger.kernel.org Subject: [PATCH iproute2 2/2] netns: add missing file close Date: Fri, 14 Aug 2015 02:56:53 +0000 Message-Id: <1439521013-22260-3-git-send-email-zhangshengju@cmss.chinamobile.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1439521013-22260-1-git-send-email-zhangshengju@cmss.chinamobile.com> References: <1439521013-22260-1-git-send-email-zhangshengju@cmss.chinamobile.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Add missing file close. Signed-off-by: Zhang Shengju --- ip/ipnetns.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ip/ipnetns.c b/ip/ipnetns.c index 088096f..d1af0c6 100644 --- a/ip/ipnetns.c +++ b/ip/ipnetns.c @@ -462,8 +462,10 @@ static int netns_pids(int argc, char **argv) if (fstat(netns, &netst) < 0) { fprintf(stderr, "Stat of netns failed: %s\n", strerror(errno)); + close(netns); return -1; } + close(netns); dir = opendir("/proc/"); if (!dir) { fprintf(stderr, "Open of /proc failed: %s\n", @@ -522,8 +524,10 @@ static int netns_identify(int argc, char **argv) if (fstat(netns, &netst) < 0) { fprintf(stderr, "Stat of netns failed: %s\n", strerror(errno)); + close(netns); return -1; } + close(netns); dir = opendir(NETNS_RUN_DIR); if (!dir) { /* Succeed treat a missing directory as an empty directory */ @@ -728,6 +732,7 @@ static int netns_set(int argc, char **argv) name, strerror(errno)); return -1; } + close(netns); return set_netnsid_from_name(name, nsid); }