From patchwork Tue Jan 20 19:26:31 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 431227 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 373C014017F for ; Wed, 21 Jan 2015 06:26:40 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753682AbbATT0f (ORCPT ); Tue, 20 Jan 2015 14:26:35 -0500 Received: from mail-ie0-f177.google.com ([209.85.223.177]:52227 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752181AbbATT0e (ORCPT ); Tue, 20 Jan 2015 14:26:34 -0500 Received: by mail-ie0-f177.google.com with SMTP id at20so12172572iec.8 for ; Tue, 20 Jan 2015 11:26:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-type:mime-version:content-transfer-encoding; bh=BBOLym028zYk1m4EApFKWxhXCcvu2TGQYzvR0MEntDk=; b=Mjr4xON9wpazkm6NtRzNTsT7cuqhhVT2kVZi8qivCiuLNho09ar49cbF5b8xKz0o88 mETldX3AxoGVA9TsAbeZKYX/wVwqHz1gzc+9fuk1DlgKapadQ39g/nlX+hXjq8lSZYpm 90rlHdvzwaeuTSuBc+pQFu/6EC6+7BUv0ae7+H5a44mYPJjBErLLsPe9wjnp6gbBDKRY OtkqgqYhM4qvHJDmMECyxGc5UNkng87yq0LAKc3pdmWXyW2qIOmGlCmOri992adMJQAZ 6bCvhVnrmIiTCwnqJvuQV+A7Rs1Nei8gsvIMWVYm3riHPquYh/6SXHRcbgLvbFJSCYgG nUsg== X-Received: by 10.50.43.169 with SMTP id x9mr28994375igl.28.1421781994032; Tue, 20 Jan 2015 11:26:34 -0800 (PST) Received: from ?IPv6:2620:0:1000:3e02:8d3b:ffb2:5065:fe88? ([2620:0:1000:3e02:8d3b:ffb2:5065:fe88]) by mx.google.com with ESMTPSA id fr4sm3516175igd.4.2015.01.20.11.26.32 (version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128/128); Tue, 20 Jan 2015 11:26:33 -0800 (PST) Message-ID: <1421781991.4832.8.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: BW regression after "tcp: refine TSO autosizing" From: Eric Dumazet To: Rick Jones Cc: Dave Taht , Eyal Perry , Yuchung Cheng , Neal Cardwell , Eyal Perry , Or Gerlitz , Linux Netdev List , Amir Vadai , Yevgeny Petrilin , Saeed Mahameed , Ido Shamay , Amir Ancel Date: Tue, 20 Jan 2015 11:26:31 -0800 In-Reply-To: <54BEA91D.1050001@hp.com> References: <54B54C72.8060705@dev.mellanox.co.il> <1421175434.4099.21.camel@edumazet-glaptop2.roam.corp.google.com> <54B590FB.5040805@dev.mellanox.co.il> <1421186430.11734.6.camel@edumazet-glaptop2.roam.corp.google.com> <1421603317.11734.154.camel@edumazet-glaptop2.roam.corp.google.com> <54BC286B.8000605@mellanox.com> <1421720216.11734.188.camel@edumazet-glaptop2.roam.corp.google.com> <1421723651.17892.3.camel@edumazet-glaptop2.roam.corp.google.com> <54BEA91D.1050001@hp.com> X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 2015-01-20 at 11:14 -0800, Rick Jones wrote: > > Thats a 3 lines patch in netperf actually. > > More stuff to pull from a TCP_INFO call I presume? Feel free to drop me > a patch, though I'd probably want it to be in the guise of the omni > output selectors. > It was something like : --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/src/nettest_omni.c b/src/nettest_omni.c index fb2d5f4..80e43ca 100644 --- a/src/nettest_omni.c +++ b/src/nettest_omni.c @@ -3465,7 +3465,7 @@ static void dump_tcp_info(struct tcp_info *tcp_info) { - printf("tcpi_rto %d tcpi_ato %d tcpi_pmtu %d tcpi_rcv_ssthresh %d\n" + fprintf(stderr, "tcpi_rto %d tcpi_ato %d tcpi_pmtu %d tcpi_rcv_ssthresh %d\n" "tcpi_rtt %d tcpi_rttvar %d tcpi_snd_ssthresh %d tpci_snd_cwnd %d\n" "tcpi_reordering %d tcpi_total_retrans %d\n", tcp_info->tcpi_rto, @@ -3539,7 +3539,7 @@ get_transport_retrans(SOCKET socket, int protocol) { } else { - if (debug > 1) { + if (debug > 1 || getenv("DUMP_TCP_INFO")) { dump_tcp_info(&tcp_info); } return tcp_info.tcpi_total_retrans;