From patchwork Sat Nov 1 15:30:20 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 405792 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E1DD2140139 for ; Sun, 2 Nov 2014 02:32:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758796AbaKAPcJ (ORCPT ); Sat, 1 Nov 2014 11:32:09 -0400 Received: from down.free-electrons.com ([37.187.137.238]:46887 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752580AbaKAPcE (ORCPT ); Sat, 1 Nov 2014 11:32:04 -0400 Received: by mail.free-electrons.com (Postfix, from userid 106) id 7D26E4B5; Sat, 1 Nov 2014 16:32:05 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from arch.hh.imgtec.org (unknown [190.2.108.156]) by mail.free-electrons.com (Postfix) with ESMTPSA id BF5614B2; Sat, 1 Nov 2014 16:32:02 +0100 (CET) From: Ezequiel Garcia To: , David Miller Cc: Thomas Petazzoni , Gregory Clement , Tawfik Bayouk , Lior Amsalem , Nadav Haklai , Ezequiel Garcia Subject: [PATCH 1/1] net: mv643xx_eth: Make TSO disabled by default Date: Sat, 1 Nov 2014 12:30:20 -0300 Message-Id: <1414855820-15094-2-git-send-email-ezequiel.garcia@free-electrons.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1414855820-15094-1-git-send-email-ezequiel.garcia@free-electrons.com> References: <1414855820-15094-1-git-send-email-ezequiel.garcia@free-electrons.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Data corruption has been observed to be produced by TSO. For instance, accessing files on a NFS-server with TSO enabled results in different data transferred each time. This has been observed only on Kirkwood platforms, i.e. with the mv643xx_eth driver. Same tests on platforms using the mvneta ethernet driver have passed without errors. Make TSO disabled by default for now, until we can found a proper fix for the regression. Fixes: 3ae8f4e0b98 ('net: mv643xx_eth: Implement software TSO') Reported-by: Slawomir Gajzner Reported-by: Julien D'Ascenzio Signed-off-by: Ezequiel Garcia --- drivers/net/ethernet/marvell/mv643xx_eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c index b151a94..8b72780 100644 --- a/drivers/net/ethernet/marvell/mv643xx_eth.c +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c @@ -3110,11 +3110,11 @@ static int mv643xx_eth_probe(struct platform_device *pdev) dev->watchdog_timeo = 2 * HZ; dev->base_addr = 0; - dev->features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_TSO; + dev->features = NETIF_F_SG | NETIF_F_IP_CSUM; dev->vlan_features = dev->features; dev->features |= NETIF_F_RXCSUM; - dev->hw_features = dev->features; + dev->hw_features = dev->features | NETIF_F_TSO; dev->priv_flags |= IFF_UNICAST_FLT; dev->gso_max_segs = MV643XX_MAX_TSO_SEGS;