diff mbox

[ethtool,1/1] bug fix: SFP Tx BIAS uses memory wrong offset

Message ID 1413367740-11118-1-git-send-email-jhs@emojatatu.com
State Not Applicable, archived
Delegated to: David Miller
Headers show

Commit Message

Jamal Hadi Salim Oct. 15, 2014, 10:09 a.m. UTC 
From: Jamal Hadi Salim <jhs@mojatatu.com>

SFF-8472 rev 12.0 indicates the SFP BIAS is at offset 100 of page A2

Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
---
 sfpdiag.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ben Hutchings Dec. 14, 2014, 5:48 p.m. UTC | #1 
On Wed, 2014-10-15 at 06:09 -0400, Jamal Hadi Salim wrote:
> From: Jamal Hadi Salim <jhs@mojatatu.com>
> 
> SFF-8472 rev 12.0 indicates the SFP BIAS is at offset 100 of page A2
> 
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>

Applied, thanks.

Ben.

> ---
>  sfpdiag.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sfpdiag.c b/sfpdiag.c
> index 812a2fa..a3dbc9b 100644
> --- a/sfpdiag.c
> +++ b/sfpdiag.c
> @@ -48,7 +48,7 @@
>  #define SFF_A2_VCC_HWARN                  12
>  #define SFF_A2_VCC_LWARN                  14
>  
> -#define SFF_A2_BIAS                       96
> +#define SFF_A2_BIAS                       100
>  #define SFF_A2_BIAS_HALRM                 16
>  #define SFF_A2_BIAS_LALRM                 18
>  #define SFF_A2_BIAS_HWARN                 20
diff mbox

Patch

diff --git a/sfpdiag.c b/sfpdiag.c
index 812a2fa..a3dbc9b 100644
--- a/sfpdiag.c
+++ b/sfpdiag.c
@@ -48,7 +48,7 @@ 
 #define SFF_A2_VCC_HWARN                  12
 #define SFF_A2_VCC_LWARN                  14
 
-#define SFF_A2_BIAS                       96
+#define SFF_A2_BIAS                       100
 #define SFF_A2_BIAS_HALRM                 16
 #define SFF_A2_BIAS_LALRM                 18
 #define SFF_A2_BIAS_HWARN                 20