Message ID | 1391038731-7501-1-git-send-email-xiyou.wangcong@gmail.com |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show |
On Wed, Jan 29, 2014 at 03:38:51PM -0800, Cong Wang wrote: > We are trying to mirror the local traffic from lo to eth0, > allowing setting mac address of lo to eth0 would make > the ether addresses in these packets correct, so that > we don't have to modify the ether header again. > > Since usually no one cares about its mac address (all-zero), > it is safe to allow those who care to set its mac address. > > Cc: Stephen Hemminger <stephen@networkplumber.org> > Cc: Eric Dumazet <edumazet@google.com> > Cc: David S. Miller <davem@davemloft.net> > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> > > --- > diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c > index c5011e0..a0ee030 100644 > --- a/drivers/net/loopback.c > +++ b/drivers/net/loopback.c > @@ -160,6 +160,7 @@ static const struct net_device_ops loopback_ops = { > .ndo_init = loopback_dev_init, > .ndo_start_xmit= loopback_xmit, > .ndo_get_stats64 = loopback_get_stats64, > + .ndo_set_mac_address = eth_mac_addr, > }; > > /* > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Seems reasonable Acked-by: Neil Horman <nhorman@tuxdriver.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jan 29, 2014 at 03:38:51PM -0800, Cong Wang wrote: > We are trying to mirror the local traffic from lo to eth0, > allowing setting mac address of lo to eth0 would make > the ether addresses in these packets correct, so that > we don't have to modify the ether header again. > > Since usually no one cares about its mac address (all-zero), > it is safe to allow those who care to set its mac address. > > Cc: Stephen Hemminger <stephen@networkplumber.org> > Cc: Eric Dumazet <edumazet@google.com> > Cc: David S. Miller <davem@davemloft.net> > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> > > --- > diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c > index c5011e0..a0ee030 100644 > --- a/drivers/net/loopback.c > +++ b/drivers/net/loopback.c > @@ -160,6 +160,7 @@ static const struct net_device_ops loopback_ops = { > .ndo_init = loopback_dev_init, > .ndo_start_xmit= loopback_xmit, > .ndo_get_stats64 = loopback_get_stats64, > + .ndo_set_mac_address = eth_mac_addr, > }; IFF_LIVE_ADDR_CHANGE would also be helpful to change mac address if loopback is already up. Also I doubt this is a change for net but for net-next. Greetings, Hannes -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Cong Wang <xiyou.wangcong@gmail.com> Date: Wed, 29 Jan 2014 15:38:51 -0800 > We are trying to mirror the local traffic from lo to eth0, > allowing setting mac address of lo to eth0 would make > the ether addresses in these packets correct, so that > we don't have to modify the ether header again. > > Since usually no one cares about its mac address (all-zero), > it is safe to allow those who care to set its mac address. > > Cc: Stephen Hemminger <stephen@networkplumber.org> > Cc: Eric Dumazet <edumazet@google.com> > Cc: David S. Miller <davem@davemloft.net> > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Please resubmit when the net-next tree opens back up. Thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jan 30, 2014 at 6:42 AM, Hannes Frederic Sowa <hannes@stressinduktion.org> wrote: > IFF_LIVE_ADDR_CHANGE would also be helpful to change mac address if loopback > is already up. > Yeah, makes sense for me. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jan 30, 2014 at 4:27 PM, David Miller <davem@davemloft.net> wrote: > Please resubmit when the net-next tree opens back up. > Fair enough, will do. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c index c5011e0..a0ee030 100644 --- a/drivers/net/loopback.c +++ b/drivers/net/loopback.c @@ -160,6 +160,7 @@ static const struct net_device_ops loopback_ops = { .ndo_init = loopback_dev_init, .ndo_start_xmit= loopback_xmit, .ndo_get_stats64 = loopback_get_stats64, + .ndo_set_mac_address = eth_mac_addr, }; /*
We are trying to mirror the local traffic from lo to eth0, allowing setting mac address of lo to eth0 would make the ether addresses in these packets correct, so that we don't have to modify the ether header again. Since usually no one cares about its mac address (all-zero), it is safe to allow those who care to set its mac address. Cc: Stephen Hemminger <stephen@networkplumber.org> Cc: Eric Dumazet <edumazet@google.com> Cc: David S. Miller <davem@davemloft.net> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html