From patchwork Wed Jan 16 06:01:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 212402 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E27262C0086 for ; Wed, 16 Jan 2013 17:01:57 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752970Ab3APGBw (ORCPT ); Wed, 16 Jan 2013 01:01:52 -0500 Received: from mail-pb0-f49.google.com ([209.85.160.49]:55934 "EHLO mail-pb0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754064Ab3APGBv (ORCPT ); Wed, 16 Jan 2013 01:01:51 -0500 Received: by mail-pb0-f49.google.com with SMTP id un15so526475pbc.36 for ; Tue, 15 Jan 2013 22:01:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:subject:from:to:cc:in-reply-to:references:content-type :date:message-id:mime-version:x-mailer:content-transfer-encoding; bh=myBy9QofxiwzkelgY5ncpSocZmFhXg8ZgUElC7aJ41U=; b=CydKRy5uornbj9+5hbex+JGR5DJ1BxVrasIZcg4pauGcupUuYOxQTys4cLdMMsRspn BYKkbwaMH+Ud4nXNhgXJSB/GkGe3gsytYsZ+pBiuKjSiFjgvqypuGUPwngq+45lWM4NN mckuD6wzxrqqEz4d/2TdTxxSyF/s/Xj8VBVjSHYquL4cdkL77yi1J23+r8l7b983icU6 VhYDAw5jGxBBD1mqgVo48RFW4jLsNDm+UVHEVWyY674YqK4tj1eL5OanLUUcQbcE+HGq Pcrzd7Ex6sIVgKEnAyi8g3W5MMfFJkKYfvEoRiZiUIXTE8CRXz7mFkDtrTB/4nbdDWMD oPXw== X-Received: by 10.68.203.129 with SMTP id kq1mr51149916pbc.30.1358316110766; Tue, 15 Jan 2013 22:01:50 -0800 (PST) Received: from [172.19.247.11] ([172.19.247.11]) by mx.google.com with ESMTPS id vq4sm11638139pbc.67.2013.01.15.22.01.49 (version=SSLv3 cipher=RC4-SHA bits=128/128); Tue, 15 Jan 2013 22:01:49 -0800 (PST) Subject: Re: 802.1q HW filter spammage in 3.7.2+ kernels. From: Eric Dumazet To: Ben Greear , David Miller Cc: netdev In-Reply-To: <50F60404.3090605@candelatech.com> References: <50F60404.3090605@candelatech.com> Date: Tue, 15 Jan 2013 22:01:48 -0800 Message-ID: <1358316108.19956.82.camel@edumazet-glaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eric Dumazet On Tue, 2013-01-15 at 17:36 -0800, Ben Greear wrote: > My kernel logs are full of this (I have 2000 macvlans). Are you using 2000 macvlans on the same device ? Interesting... I am wondering how multicast/broadcast messages don't generate a huge load and packet drops, since we clone packets for every macvlan, and queue then to netif_rx() I guess you dont use IPv6 on these macvlans ? While reviewing the code, I found this small bug. [PATCH] macvlan: fix macvlan_get_size() Signed-off-by: Eric Dumazet --- drivers/net/macvlan.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 1047e58..f4f2790 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -828,7 +828,12 @@ static int macvlan_changelink(struct net_device *dev, static size_t macvlan_get_size(const struct net_device *dev) { - return nla_total_size(4); + return + /* IFLA_MACVLAN_MODE, */ + nla_total_size(4) + + /* IFLA_MACVLAN_FLAGS */ + nla_total_size(2) + + 0; } static int macvlan_fill_info(struct sk_buff *skb,