From patchwork Thu Jun 7 06:39:17 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 163492 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 180A0B6FBC for ; Thu, 7 Jun 2012 16:39:46 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752985Ab2FGGjZ (ORCPT ); Thu, 7 Jun 2012 02:39:25 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:57366 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750713Ab2FGGjX (ORCPT ); Thu, 7 Jun 2012 02:39:23 -0400 Received: by eeit10 with SMTP id t10so76007eei.19 for ; Wed, 06 Jun 2012 23:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; bh=jbK+vE0lYTtfCb9UUx6BOEFaCpAkbFAtHSIopDX5qhk=; b=tzp3K79dYV/VvLRhI2WGsb5py58JSZ9EZULasPScuflIbySFOwnMHCGVDj0Eu8SkSd fbz8JCOTjOP6KnjEBA0wHznGPKyoHirC8tY71qg2qUkasoRkRiB2NjZSo3l6EHyESWaz Qhn/0Ct46j2ijDY6cVjHfj3WftvWoBLny6PdKUS6i4hG88Kyo9DlO4tqLxKhXyeiVs/Q nc4MuSpikT5YfuATtAFOALoNYZzI/NH2maAX0cPHJD9zUNg508Nlk4HeX8PLGqbienKx XX7SdgzU3fR1PcWAVHqQpSiEZ2plv+OCW1N8fctak0cD+9y4i7XZURmoW2kH2P3B0ar4 VPwA== Received: by 10.14.96.70 with SMTP id q46mr446878eef.231.1339051162189; Wed, 06 Jun 2012 23:39:22 -0700 (PDT) Received: from [192.168.202.172] ([74.125.121.33]) by mx.google.com with ESMTPS id c13sm7203364eeb.7.2012.06.06.23.39.18 (version=SSLv3 cipher=OTHER); Wed, 06 Jun 2012 23:39:20 -0700 (PDT) Subject: Re: 3.5.0+ - Linus GIT - WARNING: at net/sched/sch_generic.c:255 dev_watchdog+0xeb/0x15f() From: Eric Dumazet To: Miles Lane Cc: LKML , Andrew Morton , Wim Van Sebroeck , Jay Cliburn , Chris Snook , netdev , Huang Xiong In-Reply-To: References: Date: Thu, 07 Jun 2012 08:39:17 +0200 Message-ID: <1339051157.26966.97.camel@edumazet-glaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 2012-06-07 at 02:16 -0400, Miles Lane wrote: > WARNING: at net/sched/sch_generic.c:255 dev_watchdog+0xeb/0x15f() > Hardware name: UL50VT > NETDEV WATCHDOG: eth0 (atl1c): transmit queue 0 timed out > Modules linked in: hfsplus hfs vfat msdos fat snd_hrtimer ipv6 > snd_hda_codec_realtek snd_hda_intel snd_hda_codec snd_hwdep > snd_pcm_oss snd_seq_dummy snd_mixer_oss uvcvideo videobuf2_core > snd_pcm videodev snd_seq_oss snd_seq_midi snd_rawmidi media > snd_seq_midi_event acpi_cpufreq videobuf2_vmalloc videobuf2_memops > snd_seq iwlwifi snd_timer snd_seq_device asus_laptop mac80211 > sparse_keymap snd cfg80211 coretemp soundcore psmouse snd_page_alloc > rtc_cmos mperf processor evdev rfkill battery led_class input_polldev > ac i915 nouveau sr_mod cdrom sd_mod ehci_hcd atl1c uhci_hcd intel_agp > ttm usbcore intel_gtt usb_common drm_kms_helper thermal video > thermal_sys hwmon button > Pid: 3025, comm: hud-service Not tainted 3.5.0-rc1+ #128 > Call Trace: > [] warn_slowpath_common+0x7e/0x97 > [] warn_slowpath_fmt+0x41/0x43 > [] dev_watchdog+0xeb/0x15f > [] run_timer_softirq+0x20e/0x356 > [] ? run_timer_softirq+0x148/0x356 > [] ? netif_tx_unlock+0x57/0x57 > [] __do_softirq+0x103/0x239 > [] ? clockevents_program_event+0x9c/0xb9 > [] call_softirq+0x1c/0x30 > [] do_softirq+0x37/0x82 > [] irq_exit+0x4c/0xb1 > [] smp_apic_timer_interrupt+0x76/0x84 > [] apic_timer_interrupt+0x6c/0x80 > [] ? fget_raw_light+0x4c/0x7d > [] ? fget_raw_light+0x4c/0x7d > [] sys_fcntl+0x23/0x53b > [] ? print_context_stack+0x44/0xb1 > [] system_call_fastpath+0x16/0x1b > ---[ end trace c1f284d9c873031d ]--- CC netdev and Huang Xiong Atheros drivers are known to have buggy tx completion, its incredible... You could try following patch, not a 'perfect' solution, but a fix. Thanks --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c index 9cc1570..31224f3 100644 --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c @@ -1551,10 +1551,12 @@ static bool atl1c_clean_tx_irq(struct atl1c_adapter *adapter, atomic_set(&tpd_ring->next_to_clean, next_to_clean); } + spin_lock(&adapter->tx_lock); if (netif_queue_stopped(adapter->netdev) && netif_carrier_ok(adapter->netdev)) { netif_wake_queue(adapter->netdev); } + spin_unlock(&adapter->tx_lock); return true; }