From patchwork Tue Apr 10 15:15:45 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 151635 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 2EA53B76D5 for ; Wed, 11 Apr 2012 01:16:16 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759328Ab2DJPQL (ORCPT ); Tue, 10 Apr 2012 11:16:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18561 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759317Ab2DJPP7 (ORCPT ); Tue, 10 Apr 2012 11:15:59 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3AFFveu016774 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 10 Apr 2012 11:15:57 -0400 Received: from localhost (ovpn-116-50.ams2.redhat.com [10.36.116.50]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3AFFuaB009314; Tue, 10 Apr 2012 11:15:56 -0400 From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, eric.dumazet@gmail.com Subject: [patch net-next 4/5] team: ab: walk through port list non-rcu Date: Tue, 10 Apr 2012 17:15:45 +0200 Message-Id: <1334070946-7704-5-git-send-email-jpirko@redhat.com> In-Reply-To: <1334070946-7704-1-git-send-email-jpirko@redhat.com> References: <1334070946-7704-1-git-send-email-jpirko@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Since team->lock is being held, _rcu variant make no sense. Signed-off-by: Jiri Pirko --- drivers/net/team/team_mode_activebackup.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/team/team_mode_activebackup.c b/drivers/net/team/team_mode_activebackup.c index 6cde1ab..a715c40 100644 --- a/drivers/net/team/team_mode_activebackup.c +++ b/drivers/net/team/team_mode_activebackup.c @@ -72,7 +72,7 @@ static int ab_active_port_set(struct team *team, struct team_gsetter_ctx *ctx) { struct team_port *port; - list_for_each_entry_rcu(port, &team->port_list, list) { + list_for_each_entry(port, &team->port_list, list) { if (port->dev->ifindex == ctx->data.u32_val) { rcu_assign_pointer(ab_priv(team)->active_port, port); return 0;