diff mbox series

bpfilter: document build requirements for bpfilter_umh

Message ID 131136.1588999639@turing-police
State Not Applicable
Delegated to: David Miller
Headers show
Series bpfilter: document build requirements for bpfilter_umh | expand

Commit Message

Valdis Kl ē tnieks May 9, 2020, 4:47 a.m. UTC
It's not intuitively obvious that bpfilter_umh is a statically linked binary.
Mention the toolchain requirement in the Kconfig help, so people
have an easier time figuring out what's needed.

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>

Comments

Masahiro Yamada May 9, 2020, 7:51 a.m. UTC | #1
On Sat, May 9, 2020 at 1:47 PM Valdis Klētnieks <valdis.kletnieks@vt.edu> wrote:
>
> It's not intuitively obvious that bpfilter_umh is a statically linked binary.
> Mention the toolchain requirement in the Kconfig help, so people
> have an easier time figuring out what's needed.
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
>

Applied to linux-kbuild.
Thanks.


> diff --git a/net/bpfilter/Kconfig b/net/bpfilter/Kconfig
> index fed9290e3b41..0ec6c7958c20 100644
> --- a/net/bpfilter/Kconfig
> +++ b/net/bpfilter/Kconfig
> @@ -13,4 +13,8 @@ config BPFILTER_UMH
>         default m
>         help
>           This builds bpfilter kernel module with embedded user mode helper
> +
> +         Note: your toolchain must support building static binaries, since
> +         rootfs isn't mounted at the time when __init functions are called
> +         and do_execv won't be able to find the elf interpreter.
>  endif
>
diff mbox series

Patch

diff --git a/net/bpfilter/Kconfig b/net/bpfilter/Kconfig
index fed9290e3b41..0ec6c7958c20 100644
--- a/net/bpfilter/Kconfig
+++ b/net/bpfilter/Kconfig
@@ -13,4 +13,8 @@  config BPFILTER_UMH
 	default m
 	help
 	  This builds bpfilter kernel module with embedded user mode helper
+
+	  Note: your toolchain must support building static binaries, since
+	  rootfs isn't mounted at the time when __init functions are called
+	  and do_execv won't be able to find the elf interpreter.
 endif