From patchwork Thu Jul 15 12:37:18 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 58978 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id F1B86B6EF3 for ; Thu, 15 Jul 2010 22:38:56 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758483Ab0GOMhm (ORCPT ); Thu, 15 Jul 2010 08:37:42 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:49024 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754814Ab0GOMhl (ORCPT ); Thu, 15 Jul 2010 08:37:41 -0400 Received: by fxm14 with SMTP id 14so377280fxm.19 for ; Thu, 15 Jul 2010 05:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer; bh=tQbgyHdWdEl+4KqpH6T9B88lxEa+peyLUTtwXLznzNI=; b=JcdN0J/G12ID2MflKNAdvzfmCmbw69ehLltC3ioYsbeVRDMKTqO2bj/jYe1Xqwo9C3 H+dR2Olv88xeeI3J5H6fYP3HnGpcyqxdrE0QIjjCEKHd6D+KKY1OxlecaTv0CtOxq6Wr Aw0z2fAzg1dc1XG2VeeyF24s+WGgA4Ojsdh3k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=bxxY8i6z1eHFcKqpjqwqlAn0HbYSowMo1q18tqgvY11VaRxahojVj+iIE1GIyJMoeS 5SFKeDdp10vHmnGiOFKgynNQg5NSoxS2ZkEneG+vaM2GPVcidaendxAdTb1ALyZ7tz+N NHbfddIKVDZMLqR8jgkT4D+1Ae//R1PjshUmo= Received: by 10.223.107.211 with SMTP id c19mr528116fap.20.1279197459864; Thu, 15 Jul 2010 05:37:39 -0700 (PDT) Received: from localhost.localdomain (79-134-110-189.cust.suomicom.fi [79.134.110.189]) by mx.google.com with ESMTPS id a26sm305135fak.19.2010.07.15.05.37.38 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 15 Jul 2010 05:37:39 -0700 (PDT) From: Andy Shevchenko To: linux-kernel@vger.kernel.org Cc: Andy Shevchenko , Karsten Keil , Tilman Schmidt , netdev@vger.kernel.org Subject: [PATCH 1/3] drivers: isdn: use kernel macros to convert hex digit Date: Thu, 15 Jul 2010 15:37:18 +0300 Message-Id: <1279197440-6585-1-git-send-email-andy.shevchenko@gmail.com> X-Mailer: git-send-email 1.7.1.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Signed-off-by: Andy Shevchenko Cc: Karsten Keil Cc: Tilman Schmidt Cc: netdev@vger.kernel.org --- drivers/isdn/capi/capidrv.c | 7 ++----- drivers/isdn/hisax/q931.c | 13 ++----------- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/isdn/capi/capidrv.c b/drivers/isdn/capi/capidrv.c index bf55ed5..2978bda 100644 --- a/drivers/isdn/capi/capidrv.c +++ b/drivers/isdn/capi/capidrv.c @@ -1450,12 +1450,9 @@ static void handle_dtrace_data(capidrv_contr *card, } for (p = data, end = data+len; p < end; p++) { - u8 w; PUTBYTE_TO_STATUS(card, ' '); - w = (*p >> 4) & 0xf; - PUTBYTE_TO_STATUS(card, (w < 10) ? '0'+w : 'A'-10+w); - w = *p & 0xf; - PUTBYTE_TO_STATUS(card, (w < 10) ? '0'+w : 'A'-10+w); + PUTBYTE_TO_STATUS(card, hex_asc_hi(*p)); + PUTBYTE_TO_STATUS(card, hex_asc_lo(*p)); } PUTBYTE_TO_STATUS(card, '\n'); diff --git a/drivers/isdn/hisax/q931.c b/drivers/isdn/hisax/q931.c index 8b853d5..c0771f9 100644 --- a/drivers/isdn/hisax/q931.c +++ b/drivers/isdn/hisax/q931.c @@ -1152,20 +1152,11 @@ QuickHex(char *txt, u_char * p, int cnt) { register int i; register char *t = txt; - register u_char w; for (i = 0; i < cnt; i++) { *t++ = ' '; - w = (p[i] >> 4) & 0x0f; - if (w < 10) - *t++ = '0' + w; - else - *t++ = 'A' - 10 + w; - w = p[i] & 0x0f; - if (w < 10) - *t++ = '0' + w; - else - *t++ = 'A' - 10 + w; + *t++ = hex_asc_hi(p[i]); + *t++ = hex_asc_lo(p[i]); } *t++ = 0; return (t - txt);