diff mbox

[1/2] iproute2 skbedit: Fix help message

Message ID 1259846844.3766.36.camel@bigi
State Accepted, archived
Delegated to: stephen hemminger
Headers show

Commit Message

jamal Dec. 3, 2009, 1:27 p.m. UTC 
Currently the help text for skbedit implies you can either pass queue
mapping or priority. Truth is you can pass both

cheers,
jamal
commit ca50bc332fc8f2cba0468fe133d41d78a0be7b71
Author: Jamal Hadi Salim <hadi@cyberus.ca>
Date:   Thu Dec 3 08:14:11 2009 -0500

    skbedit: Fix help message
    
    Currently the help text implies you can either pass queue mapping
    or priority. Truth is you can pass both
    
    Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
    Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>

Comments

stephen hemminger Dec. 26, 2009, 7:07 p.m. UTC | #1 
On Thu, 03 Dec 2009 08:27:24 -0500
jamal <hadi@cyberus.ca> wrote:

> 
> Currently the help text for skbedit implies you can either pass queue
> mapping or priority. Truth is you can pass both
> 
> cheers,
> jamal
> 
applied to 2.6.32 version
jamal Dec. 26, 2009, 9:12 p.m. UTC | #2 
On Sat, 2009-12-26 at 11:07 -0800, Stephen Hemminger wrote:
> On Thu, 03 Dec 2009 08:27:24 -0500
> jamal <hadi@cyberus.ca> wrote:
> 
> > 
> > Currently the help text for skbedit implies you can either pass queue
> > mapping or priority. Truth is you can pass both
> > 
> > cheers,
> > jamal
> > 
> applied to 2.6.32 version

It is not in the 2.6.32 release - but seems harmless enough it can stay
in later versions.

cheers,
jamal

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/tc/m_skbedit.c b/tc/m_skbedit.c
index 9044353..ecb1f2d 100644
--- a/tc/m_skbedit.c
+++ b/tc/m_skbedit.c
@@ -31,8 +31,9 @@ 
 static void
 explain(void)
 {
-	fprintf(stderr, "Usage: ... skbedit "
-			"queue_mapping QUEUE_MAPPING | priority PRIORITY \n"
+	fprintf(stderr, "Usage: ... skbedit <[QM] [PM]>\n"
+			"QM = queue_mapping QUEUE_MAPPING\n"
+			"PM = priority PRIORITY \n"
 			"QUEUE_MAPPING = device transmit queue to use\n"
 			"PRIORITY = classID to assign to priority field\n");
 }