diff mbox

[net-2.6,1/2] qlge: Fix early exit from mbox cmd complete wait.

Message ID 1257529498-17459-2-git-send-email-ron.mercer@qlogic.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Ron Mercer Nov. 6, 2009, 5:44 p.m. UTC
This line was accidentally left out of the previous commit #
da03945140a035a2962f7f93e359085596f20499.

Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
---
 drivers/net/qlge/qlge_mpi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

David Miller Nov. 7, 2009, 4:35 a.m. UTC | #1
From: Ron Mercer <ron.mercer@qlogic.com>
Date: Fri,  6 Nov 2009 09:44:57 -0800

> This line was accidentally left out of the previous commit #
> da03945140a035a2962f7f93e359085596f20499.
> 
> Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>

Applied, but please provide a text string of the commit's
header line when referencing a commit, don't just provide
the SHA1 ID as that can be not referencable in a -stable
backport.

Here is how I fixed up your commit message so that you can
see how to form it next time, thanks.

qlge: Fix early exit from mbox cmd complete wait.

This line was accidentally left out of the previous commit #
da03945140a035a2962f7f93e359085596f20499 ("qlge: Fix firmware mailbox
command timeout.").

Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ron Mercer Nov. 7, 2009, 6:32 p.m. UTC | #2
On Fri, Nov 06, 2009 at 08:35:32PM -0800, David Miller wrote:
> From: Ron Mercer <ron.mercer@qlogic.com>
> Date: Fri,  6 Nov 2009 09:44:57 -0800
> 
> 
> Applied, but please provide a text string of the commit's
> header line when referencing a commit, don't just provide
> the SHA1 ID as that can be not referencable in a -stable
> backport.
>

Dave,

Will do.  Thanks for the fix up and instructions.

Ron
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/qlge/qlge_mpi.c b/drivers/net/qlge/qlge_mpi.c
index bcf13c9..aec05f2 100644
--- a/drivers/net/qlge/qlge_mpi.c
+++ b/drivers/net/qlge/qlge_mpi.c
@@ -499,7 +499,7 @@  static int ql_mailbox_command(struct ql_adapter *qdev, struct mbox_params *mbcp)
 		/* Wait for the interrupt to come in. */
 		status = ql_wait_mbx_cmd_cmplt(qdev);
 		if (status)
-			goto end;
+			continue;
 
 		/* Process the event.  If it's an AEN, it
 		 * will be handled in-line or a worker