Message ID | 1227295576.5624@xw6200 |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: "Matt Carlson" <mcarlson@broadcom.com> Date: Fri, 21 Nov 2008 11:02:15 -0800 > The ENABLE_APE flag tells the driver whether or not the device has an > Application Processing Engine (APE). The APE does not need the PHY to > be powered unless it is running management firmware. For backwards > compatibility, management firmware will still set the ENABLE_ASF bit. > Consequently, there is no reason to consider the ENABLE_APE flag when > deciding whether or not to power down the phy. > > Signed-off-by: Matt Carlson <mcarlson@broadcom.com> > Signed-off-by: Michael Chan <mchan@broadcom.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 89d897d..07bf056 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -2400,8 +2400,7 @@ static int tg3_set_power_state(struct tg3 *tp, pci_power_t state) } if (!(device_should_wake) && - !(tp->tg3_flags & TG3_FLAG_ENABLE_ASF) && - !(tp->tg3_flags3 & TG3_FLG3_ENABLE_APE)) + !(tp->tg3_flags & TG3_FLAG_ENABLE_ASF)) tg3_power_down_phy(tp, do_low_power); tg3_frob_aux_power(tp);