From patchwork Wed Dec 28 11:26:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Ricardo Leitner X-Patchwork-Id: 709214 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3tpVnx2n6rz9t0m for ; Wed, 28 Dec 2016 22:27:33 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="tZqb7U7G"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751443AbcL1L12 (ORCPT ); Wed, 28 Dec 2016 06:27:28 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:33861 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751328AbcL1L1Z (ORCPT ); Wed, 28 Dec 2016 06:27:25 -0500 Received: by mail-qt0-f193.google.com with SMTP id p16so23690048qta.1; Wed, 28 Dec 2016 03:27:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=wtuxJ1syTvJJbC+0eYw+HjlETPMFr+llGmSBtXP6ax8=; b=tZqb7U7G0HHBamOh+o31qBoPopfJAn+xQk63i3FFSyAJu72Xrkj99VOwiIOTiwYDxw GU/iFzJUdUnF6eLjspNzhJnSxZBY3GKKbtSUlcXBbyyMu3es3qzBO27uMHGclgKqO/Fe z1NnLCWcWiBSz5x5HYZ+4xPrZkYeCiP5nur7nnb8N+uMKU8FuZIq7ChwaDr6vPcFMgwS ZmABLCNW/L8q226uJwDH3StZzvKCL5dcX27JFCMvsWwPP6wo1POuJ6Cctx2NxAB6LEXS pGE42rAyc4XLmHok6xygWeJCxaiECqPR9Q4Fm0q9gJ4Gd3R96ufyi+S7lmdDaZ6A4t1C CB1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wtuxJ1syTvJJbC+0eYw+HjlETPMFr+llGmSBtXP6ax8=; b=AseXqIEGFx7DRzgZUcG77OG2MkP9YlTzvDrr8/wurg4gdmfeO+6bRGUhHt6/GDYWRz uknt2/Z8AHBXHIWk1sg/PYFajGl48ng5XLKVxkiXoOJOxfp7Q1tz/VTlQAa8gEzYJYXg sEybUSnuu3sbfncS9L7ce5E0D+WdkfyiFZYy82WSmRISAP7XU4HAXBPFNYO7dTo7x9yY HuF98znOTCMAJZCKbVv8t0TYhcRdVaV/L+3R+4YaPec9Cq9Hwrp+HU1ZjRaMjrbLMbsI Hi+mPCz9UGyUwH0WAgpxA5NgatgOdgISVYeCiiF8rtIo6Va8DJhU/9vAb1b/PY0LAnEf Harw== X-Gm-Message-State: AIkVDXJcyY+0z78Ox050bI4u840n0DvbbEwU79dZNuSnbPtY6SVRPhdt+rQpwU1QagZRWg== X-Received: by 10.200.42.170 with SMTP id b39mr36811265qta.55.1482924445099; Wed, 28 Dec 2016 03:27:25 -0800 (PST) Received: from localhost.localdomain.com ([2804:7f4:3381:1ed0::1]) by smtp.gmail.com with ESMTPSA id q53sm30590477qtq.0.2016.12.28.03.27.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Dec 2016 03:27:24 -0800 (PST) From: Marcelo Ricardo Leitner To: netdev@vger.kernel.org Cc: linux-sctp@vger.kernel.org, Vlad Yasevich , Neil Horman Subject: [PATCH RESEND net-next 5/5] sctp: sctp_chunk_length_valid should return bool Date: Wed, 28 Dec 2016 09:26:35 -0200 Message-Id: <11191de6d1bbf1548f1dc7aa1d1eb0ff469e6998.1482924092.git.marcelo.leitner@gmail.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Signed-off-by: Marcelo Ricardo Leitner --- net/sctp/sm_statefuns.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c index 9a223d5b2314ff166be0446462c33219b7eec1b9..3382ef254e7b41ae4723f2e72e5aca30d46a4a8e 100644 --- a/net/sctp/sm_statefuns.c +++ b/net/sctp/sm_statefuns.c @@ -160,23 +160,22 @@ static sctp_disposition_t __sctp_sf_do_9_1_abort(struct net *net, /* Small helper function that checks if the chunk length * is of the appropriate length. The 'required_length' argument * is set to be the size of a specific chunk we are testing. - * Return Values: 1 = Valid length - * 0 = Invalid length + * Return Values: true = Valid length + * false = Invalid length * */ -static inline int -sctp_chunk_length_valid(struct sctp_chunk *chunk, - __u16 required_length) +static inline bool +sctp_chunk_length_valid(struct sctp_chunk *chunk, __u16 required_length) { __u16 chunk_length = ntohs(chunk->chunk_hdr->length); /* Previously already marked? */ if (unlikely(chunk->pdiscard)) - return 0; + return false; if (unlikely(chunk_length < required_length)) - return 0; + return false; - return 1; + return true; } /**********************************************************