| Message ID | 0537d23a6178c8507f3fda2ab8e0140b6117ef74.1607488953.git.pavana.sharma@digi.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for mv88e6393x family of Marvell | expand |
On Wed, Dec 09, 2020 at 03:03:47PM +1000, Pavana Sharma wrote: > Add 5gbase-r PHY interface mode. > > Signed-off-by: Pavana Sharma <pavana.sharma@digi.com> > --- > Documentation/devicetree/bindings/net/ethernet-controller.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > index fdf709817218..aa6ae7851de9 100644 > --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml > +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > @@ -89,6 +89,8 @@ properties: > - trgmii > - 1000base-x > - 2500base-x > + # 5GBASE-R > + - 5gbase-r > - rxaui > - xaui Hi Pavana For v10 i said: > What value does the comment add? I don't remember you replying. Why is 5gbase-r special and it needs a comment, saying the same thing in CAPS LETTERS? What value is there in the CAPS LETTERS string? Thanks Andrew
Hi Andrew, > For v10 i said: > > What value does the comment add? > I don't remember you replying. Why is 5gbase-r special and it needs a > comment, saying the same thing in CAPS LETTERS? What value is there in > the CAPS LETTERS string? There isn't anything special regarding 5gbase-r apart from another supported speed. So, I will remove the comment from [PATCH 1 & 2] and keep it similar to other (1000/2500) speed options. Thanks, Pavana
diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml index fdf709817218..aa6ae7851de9 100644 --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml @@ -89,6 +89,8 @@ properties: - trgmii - 1000base-x - 2500base-x + # 5GBASE-R + - 5gbase-r - rxaui - xaui
Add 5gbase-r PHY interface mode. Signed-off-by: Pavana Sharma <pavana.sharma@digi.com> --- Documentation/devicetree/bindings/net/ethernet-controller.yaml | 2 ++ 1 file changed, 2 insertions(+)