mbox series

[bpf,0/1] runqslower: fix Makefile

Message ID cover.1580348836.git.hex@fb.com
Headers show
Series runqslower: fix Makefile | expand

Message

Yulia Kartseva Jan. 30, 2020, 2:09 a.m. UTC
From: Julia Kartseva <hex@fb.com>

Fix undefined reference linker errors when building runqslower with
gcc 7.4.0 on Ubuntu 18.04.
The issue is with misplaced -lelf, -lz options in Makefile:
$(Q)$(CC) $(CFLAGS) -lelf -lz $^ -o $@

-lelf, -lz options should follow the list of target dependencies:
$(Q)$(CC) $(CFLAGS) $^ -lelf -lz -o $@
or after substitution
cc -g -Wall runqslower.o libbpf.a -lelf -lz -o runqslower

The current order of gcc params causes failure in libelf symbols resolution,
e.g. undefined reference to `elf_memory'

Julia Kartseva (1):
  runqslower: fix Makefile

 tools/bpf/runqslower/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)