| Message ID | 20201106090117.3755588-1-liuhangbin@gmail.com |
|---|---|
| Headers | show |
| Series | Remove unused test_ipip.sh test and add missed ip6ip6 test | expand |
On Fri, 6 Nov 2020 17:01:15 +0800 Hangbin Liu wrote: > In comment 173ca26e9b51 ("samples/bpf: add comprehensive ipip, ipip6, > ip6ip6 test") we added some bpf tunnel tests. In commit 933a741e3b82 > ("selftests/bpf: bpf tunnel test.") when we moved it to the current > folder, we missed some points: > > 1. ip6ip6 test is not added > 2. forgot to remove test_ipip.sh in sample folder > 3. TCP test code is not removed in test_tunnel_kern.c > > In this patch set I add back ip6ip6 test and remove unused code. I'm not sure > if this should be net or net-next, so just set to net. I'm assuming you meant to tag this with the bpf tree.
On Fri, Nov 6, 2020 at 10:56 AM Jakub Kicinski <kuba@kernel.org> wrote: > > On Fri, 6 Nov 2020 17:01:15 +0800 Hangbin Liu wrote: > > In comment 173ca26e9b51 ("samples/bpf: add comprehensive ipip, ipip6, > > ip6ip6 test") we added some bpf tunnel tests. In commit 933a741e3b82 > > ("selftests/bpf: bpf tunnel test.") when we moved it to the current > > folder, we missed some points: > > > > 1. ip6ip6 test is not added > > 2. forgot to remove test_ipip.sh in sample folder > > 3. TCP test code is not removed in test_tunnel_kern.c > > > > In this patch set I add back ip6ip6 test and remove unused code. I'm not sure > > if this should be net or net-next, so just set to net. > > I'm assuming you meant to tag this with the bpf tree. Right. Thanks for headsup.
On Fri, Nov 06, 2020 at 10:56:00AM -0800, Jakub Kicinski wrote: > On Fri, 6 Nov 2020 17:01:15 +0800 Hangbin Liu wrote: > > In comment 173ca26e9b51 ("samples/bpf: add comprehensive ipip, ipip6, > > ip6ip6 test") we added some bpf tunnel tests. In commit 933a741e3b82 > > ("selftests/bpf: bpf tunnel test.") when we moved it to the current > > folder, we missed some points: > > > > 1. ip6ip6 test is not added > > 2. forgot to remove test_ipip.sh in sample folder > > 3. TCP test code is not removed in test_tunnel_kern.c > > > > In this patch set I add back ip6ip6 test and remove unused code. I'm not sure > > if this should be net or net-next, so just set to net. > > I'm assuming you meant to tag this with the bpf tree. Ah, yes, I mean to bpf tree. Sorry for the mistake. Regards Hangbin
In comment 173ca26e9b51 ("samples/bpf: add comprehensive ipip, ipip6, ip6ip6 test") we added some bpf tunnel tests. In commit 933a741e3b82 ("selftests/bpf: bpf tunnel test.") when we moved it to the current folder, we missed some points: 1. ip6ip6 test is not added 2. forgot to remove test_ipip.sh in sample folder 3. TCP test code is not removed in test_tunnel_kern.c In this patch set I add back ip6ip6 test and remove unused code. I'm not sure if this should be net or net-next, so just set to net. Here is the test result: ``` Testing IP6IP6 tunnel... PING ::11(::11) 56 data bytes --- ::11 ping statistics --- 3 packets transmitted, 3 received, 0% packet loss, time 63ms rtt min/avg/max/mdev = 0.014/1028.308/2060.906/841.361 ms, pipe 2 PING 1::11(1::11) 56 data bytes --- 1::11 ping statistics --- 3 packets transmitted, 3 received, 0% packet loss, time 48ms rtt min/avg/max/mdev = 0.026/0.029/0.036/0.006 ms PING 1::22(1::22) 56 data bytes --- 1::22 ping statistics --- 3 packets transmitted, 3 received, 0% packet loss, time 47ms rtt min/avg/max/mdev = 0.030/0.048/0.067/0.016 ms PASS: ip6ip6tnl ``` v2: Keep ip6ip6 section in test_tunnel_kern.c. Hangbin Liu (2): selftest/bpf: add missed ip6ip6 test back samples/bpf: remove unused test_ipip.sh samples/bpf/test_ipip.sh | 179 ------------------ .../selftests/bpf/progs/test_tunnel_kern.c | 44 +---- tools/testing/selftests/bpf/test_tunnel.sh | 43 ++++- 3 files changed, 44 insertions(+), 222 deletions(-) delete mode 100755 samples/bpf/test_ipip.sh