mbox series

[net,0/2] vsock: fix null pointer dereference and cleanup in vsock_poll()

Message ID 20200811095504.25051-1-sgarzare@redhat.com
Headers show
Series vsock: fix null pointer dereference and cleanup in vsock_poll() | expand

Message

Stefano Garzarella Aug. 11, 2020, 9:55 a.m. UTC 
The first patch fixes a potential null pointer dereference in vsock_poll()
reported by syzbot.
The second patch is a simple cleanup in the same block code. I put this later,
to make it easier to backport the first patch in the stable branches.

Thanks,
Stefano

Stefano Garzarella (2):
  vsock: fix potential null pointer dereference in vsock_poll()
  vsock: small cleanup in vsock_poll()

 net/vmw_vsock/af_vsock.c | 27 ++++++++++++---------------
 1 file changed, 12 insertions(+), 15 deletions(-)

Comments

David Miller Aug. 11, 2020, 5:24 p.m. UTC | #1 
From: Stefano Garzarella <sgarzare@redhat.com>
Date: Tue, 11 Aug 2020 11:55:02 +0200

> The first patch fixes a potential null pointer dereference in vsock_poll()
> reported by syzbot.
> The second patch is a simple cleanup in the same block code. I put this later,
> to make it easier to backport the first patch in the stable branches.

Please do not mix cleanups and bug fixes into the same patch series.

net-next is closed, so you should not be submitting non-bugfixes at
this time.
Stefano Garzarella Aug. 12, 2020, 7:17 a.m. UTC | #2 
On Tue, Aug 11, 2020 at 10:24:18AM -0700, David Miller wrote:
> From: Stefano Garzarella <sgarzare@redhat.com>
> Date: Tue, 11 Aug 2020 11:55:02 +0200
> 
> > The first patch fixes a potential null pointer dereference in vsock_poll()
> > reported by syzbot.
> > The second patch is a simple cleanup in the same block code. I put this later,
> > to make it easier to backport the first patch in the stable branches.
> 
> Please do not mix cleanups and bug fixes into the same patch series.

I did it because I was going through the same part of the code,
but I won't do it again!

> 
> net-next is closed, so you should not be submitting non-bugfixes at
> this time.
> 

I'll resend only the first patch, sorry for the noise.

Thanks,
Stefano