| Message ID | 20200704124507.3336497-1-olteanv@gmail.com |
|---|---|
| Headers | show |
| Series | PHYLINK integration improvements for Felix DSA driver | expand |
From: Vladimir Oltean <olteanv@gmail.com> Date: Sat, 4 Jul 2020 15:45:01 +0300 > From: Vladimir Oltean <vladimir.oltean@nxp.com> > > This is an overhaul of the Felix switch driver's PHYLINK operations. > > Patches 1, 3, 4 and 5 are cleanup, patch 2 is adding a new feature and > and patch 6 is adaptation to the new format of an existing phylink API > (mac_link_up). > > Changes since v1: > - Now using phy_clear_bits and phy_set_bits instead of plain writes to > MII_BMCR. This combines former patches 1/7 and 6/7 into a single new > patch 1/6. > - Updated commit message of patch 5/6. Series applied, thanks.
On Sun, Jul 05, 2020 at 03:26:20PM -0700, David Miller wrote: > From: Vladimir Oltean <olteanv@gmail.com> > Date: Sat, 4 Jul 2020 15:45:01 +0300 > > > From: Vladimir Oltean <vladimir.oltean@nxp.com> > > > > This is an overhaul of the Felix switch driver's PHYLINK operations. > > > > Patches 1, 3, 4 and 5 are cleanup, patch 2 is adding a new feature and > > and patch 6 is adaptation to the new format of an existing phylink API > > (mac_link_up). > > > > Changes since v1: > > - Now using phy_clear_bits and phy_set_bits instead of plain writes to > > MII_BMCR. This combines former patches 1/7 and 6/7 into a single new > > patch 1/6. > > - Updated commit message of patch 5/6. > > Series applied, thanks. v3 was posted yesterday...
From: Russell King - ARM Linux admin <linux@armlinux.org.uk> Date: Mon, 6 Jul 2020 09:45:04 +0100 > v3 was posted yesterday... My tree is immutable, so you know what that means :-)
On Mon, Jul 06, 2020 at 12:54:54PM -0700, David Miller wrote: > From: Russell King - ARM Linux admin <linux@armlinux.org.uk> > Date: Mon, 6 Jul 2020 09:45:04 +0100 > > > v3 was posted yesterday... > > My tree is immutable, so you know what that means :-) I was wondering whether there was a reason why you merged v2 when v3 had already been posted.
From: Russell King - ARM Linux admin <linux@armlinux.org.uk> Date: Mon, 6 Jul 2020 21:39:24 +0100 > On Mon, Jul 06, 2020 at 12:54:54PM -0700, David Miller wrote: >> From: Russell King - ARM Linux admin <linux@armlinux.org.uk> >> Date: Mon, 6 Jul 2020 09:45:04 +0100 >> >> > v3 was posted yesterday... >> >> My tree is immutable, so you know what that means :-) > > I was wondering whether there was a reason why you merged v2 when v3 had > already been posted. I simply missed it, so relative fixups need to be sent to me.
On 7/6/2020 1:46 PM, David Miller wrote: > From: Russell King - ARM Linux admin <linux@armlinux.org.uk> > Date: Mon, 6 Jul 2020 21:39:24 +0100 > >> On Mon, Jul 06, 2020 at 12:54:54PM -0700, David Miller wrote: >>> From: Russell King - ARM Linux admin <linux@armlinux.org.uk> >>> Date: Mon, 6 Jul 2020 09:45:04 +0100 >>> >>>> v3 was posted yesterday... >>> >>> My tree is immutable, so you know what that means :-) >> >> I was wondering whether there was a reason why you merged v2 when v3 had >> already been posted. > > I simply missed it, so relative fixups need to be sent to me. The changes were more about the commit message than the code itself... so I am not sure how this can be fixed without a fixup! or squash! commit which you probably would not do since it would amount to rewriting history.
From: Vladimir Oltean <vladimir.oltean@nxp.com> This is an overhaul of the Felix switch driver's PHYLINK operations. Patches 1, 3, 4 and 5 are cleanup, patch 2 is adding a new feature and and patch 6 is adaptation to the new format of an existing phylink API (mac_link_up). Changes since v1: - Now using phy_clear_bits and phy_set_bits instead of plain writes to MII_BMCR. This combines former patches 1/7 and 6/7 into a single new patch 1/6. - Updated commit message of patch 5/6. Vladimir Oltean (6): net: dsa: felix: clarify the intention of writes to MII_BMCR net: dsa: felix: support half-duplex link modes net: dsa: felix: unconditionally configure MAC speed to 1000Mbps net: dsa: felix: set proper pause frame timers based on link speed net: dsa: felix: delete .phylink_mac_an_restart code net: dsa: felix: use resolved link config in mac_link_up() drivers/net/dsa/ocelot/felix.c | 108 +++++---- drivers/net/dsa/ocelot/felix.h | 11 +- drivers/net/dsa/ocelot/felix_vsc9959.c | 298 ++++++++++++------------- include/linux/fsl/enetc_mdio.h | 1 + 4 files changed, 213 insertions(+), 205 deletions(-)