mbox series

[V1,net,0/2] Fix xdp in ena driver

Message ID 20200602132151.366-1-sameehj@amazon.com
Headers show
Series Fix xdp in ena driver | expand

Message

Jubran, Samih June 2, 2020, 1:21 p.m. UTC
From: Sameeh Jubran <sameehj@amazon.com>

This patchset includes 2 XDP related bug fixes.

Sameeh Jubran (2):
  net: ena: xdp: XDP_TX: fix memory leak
  net: ena: xdp: update napi budget for DROP and ABORTED

 drivers/net/ethernet/amazon/ena/ena_netdev.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Jakub Kicinski June 2, 2020, 4:23 p.m. UTC | #1
On Tue, 2 Jun 2020 13:21:49 +0000 sameehj@amazon.com wrote:
> From: Sameeh Jubran <sameehj@amazon.com>
> 
> This patchset includes 2 XDP related bug fixes.

Both of them have this problem

Fixes tag: Fixes: cad451dd2427 ("net: ena: Implement XDP_TX action")
Has these problem(s):
	- Subject does not match target commit subject
	  Just use
		git log -1 --format='Fixes: %h ("%s")'
David Miller June 2, 2020, 10:42 p.m. UTC | #2
From: <sameehj@amazon.com>
Date: Tue, 2 Jun 2020 13:21:49 +0000

> From: Sameeh Jubran <sameehj@amazon.com>
> 
> This patchset includes 2 XDP related bug fixes.

Series applied and queued up for v5.6 -stable, thanks.
David Miller June 2, 2020, 10:44 p.m. UTC | #3
From: Jakub Kicinski <kuba@kernel.org>
Date: Tue, 2 Jun 2020 09:23:33 -0700

> On Tue, 2 Jun 2020 13:21:49 +0000 sameehj@amazon.com wrote:
>> From: Sameeh Jubran <sameehj@amazon.com>
>> 
>> This patchset includes 2 XDP related bug fixes.
> 
> Both of them have this problem
> 
> Fixes tag: Fixes: cad451dd2427 ("net: ena: Implement XDP_TX action")
> Has these problem(s):
> 	- Subject does not match target commit subject
> 	  Just use
> 		git log -1 --format='Fixes: %h ("%s")'

Whoops, I'll revert, please fix this up.
Jubran, Samih June 3, 2020, 8:54 a.m. UTC | #4
> -----Original Message-----
> From: David Miller <davem@davemloft.net>
> Sent: Wednesday, June 3, 2020 1:44 AM
> To: kuba@kernel.org
> Cc: Jubran, Samih <sameehj@amazon.com>; netdev@vger.kernel.org;
> Woodhouse, David <dwmw@amazon.co.uk>; Machulsky, Zorik
> <zorik@amazon.com>; Matushevsky, Alexander <matua@amazon.com>;
> Bshara, Saeed <saeedb@amazon.com>; Wilson, Matt <msw@amazon.com>;
> Liguori, Anthony <aliguori@amazon.com>; Bshara, Nafea
> <nafea@amazon.com>; Tzalik, Guy <gtzalik@amazon.com>; Belgazal,
> Netanel <netanel@amazon.com>; Saidi, Ali <alisaidi@amazon.com>;
> Herrenschmidt, Benjamin <benh@amazon.com>; Kiyanovski, Arthur
> <akiyano@amazon.com>; Dagan, Noam <ndagan@amazon.com>
> Subject: RE: [EXTERNAL] [PATCH V1 net 0/2] Fix xdp in ena driver
> 
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
> 
> 
> 
> From: Jakub Kicinski <kuba@kernel.org>
> Date: Tue, 2 Jun 2020 09:23:33 -0700
> 
> > On Tue, 2 Jun 2020 13:21:49 +0000 sameehj@amazon.com wrote:
> >> From: Sameeh Jubran <sameehj@amazon.com>
> >>
> >> This patchset includes 2 XDP related bug fixes.
> >
> > Both of them have this problem
> >
> > Fixes tag: Fixes: cad451dd2427 ("net: ena: Implement XDP_TX action")
> > Has these problem(s):
> >       - Subject does not match target commit subject
> >         Just use
> >               git log -1 --format='Fixes: %h ("%s")'
> 
> Whoops, I'll revert, please fix this up.

Sorry, fixed in V2.