mbox series

[iproute2,v2,0/2] bpf: memory access fixes

Message ID 20200422102808.9197-1-jhs@emojatatu.com
Headers show
Series bpf: memory access fixes | expand

Message

Jamal Hadi Salim April 22, 2020, 10:28 a.m. UTC 
From: Jamal Hadi Salim <hadi@mojatatu.com>

Changes from V1:
 1) use snprintf instead of sprintf and fix corresponding error message.
 Caught-by: Dominique Martinet <asmadeus@codewreck.org>
 2) Fix memory leak and extraneous free() in error path

Jamal Hadi Salim (2):
  bpf: Fix segfault when custom pinning is used
  bpf: Fix mem leak and extraneous free() in error path

 lib/bpf.c | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

Comments

Stephen Hemminger April 30, 2020, 5:40 a.m. UTC | #1 
On Wed, 22 Apr 2020 06:28:06 -0400
Jamal Hadi Salim <jhs@mojatatu.com> wrote:

> From: Jamal Hadi Salim <hadi@mojatatu.com>
> 
> Changes from V1:
>  1) use snprintf instead of sprintf and fix corresponding error message.
>  Caught-by: Dominique Martinet <asmadeus@codewreck.org>
>  2) Fix memory leak and extraneous free() in error path
> 
> Jamal Hadi Salim (2):
>   bpf: Fix segfault when custom pinning is used
>   bpf: Fix mem leak and extraneous free() in error path
> 
>  lib/bpf.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 

Would be good to see a v3 and ideally ACK's from of the
other BPF developers such as Daniel Borkmann
or Jakub Kiciniski