mbox series

[net-next,v1,0/3] Add additional EHL PCI info and PCI ID

Message ID 20200320164825.14200-1-weifeng.voon@intel.com
Headers show
Series Add additional EHL PCI info and PCI ID | expand

Message

Voon, Weifeng March 20, 2020, 4:48 p.m. UTC 
Intel EHL consist of 3 identical MAC. 2 are located in the Intel(R)
Programmable Services Engine (Intel(R) PSE) and 1 is located in the
platform Controller Hub (PCH). Each MAC consist of 3 PCI IDs which are
differentiated by MII and speed.

Voon Weifeng (3):
  net: stmmac: add EHL PSE0 & PSE1 1Gbps PCI info and PCI ID
  net: stmmac: add EHL PSE0 & PSE1 2.5Gbps PCI info and PCI ID
  net: stmmac: add EHL SGMII 2.5Gbps PCI info and PCI ID

 .../net/ethernet/stmicro/stmmac/stmmac_pci.c  | 92 +++++++++++++++++--
 1 file changed, 86 insertions(+), 6 deletions(-)

Comments

Jose Abreu March 23, 2020, 9:54 a.m. UTC | #1 
From: Voon Weifeng <weifeng.voon@intel.com>
Date: Mar/20/2020, 16:48:22 (UTC+00:00)

> Intel EHL consist of 3 identical MAC. 2 are located in the Intel(R)
> Programmable Services Engine (Intel(R) PSE) and 1 is located in the
> platform Controller Hub (PCH). Each MAC consist of 3 PCI IDs which are
> differentiated by MII and speed.

This stmmac_pci.c is getting bigger and bigger ... Can you consider adding 
your own PCI driver (dwmac-intel.c) to stmmac tree ?

You could even submit a patch for MAINTAINERS for this particular driver 
as it's already done for others.

---
Thanks,
Jose Miguel Abreu
Voon, Weifeng March 23, 2020, 3:58 p.m. UTC | #2 
> > Intel EHL consist of 3 identical MAC. 2 are located in the Intel(R)
> > Programmable Services Engine (Intel(R) PSE) and 1 is located in the
> > platform Controller Hub (PCH). Each MAC consist of 3 PCI IDs which are
> > differentiated by MII and speed.
> 
> This stmmac_pci.c is getting bigger and bigger ... Can you consider
> adding your own PCI driver (dwmac-intel.c) to stmmac tree ?

Good idea. I will rework on this and submit as v2. Thanks. 

> 
> You could even submit a patch for MAINTAINERS for this particular driver
> as it's already done for others.

Do you mean becoming the maintainer for this particular file?

Regards,
Weifeng

> 
> ---
> Thanks,
> Jose Miguel Abreu