mbox series

[net-next,00/15] ethtool: consolidate irq coalescing - part 3

Message ID 20200310021512.1861626-1-kuba@kernel.org
Headers show
Series ethtool: consolidate irq coalescing - part 3 | expand

Message

Jakub Kicinski March 10, 2020, 2:14 a.m. UTC 
Hi!

Convert more drivers following the groundwork laid in a recent
patch set [1] and continued in [2]. The aim of the effort is to
consolidate irq coalescing parameter validation in the core.

This set converts 15 drivers in drivers/net/ethernet.
3 more conversion sets to come.

None of the drivers here checked all unsupported parameters.

[1] https://lore.kernel.org/netdev/20200305051542.991898-1-kuba@kernel.org/
[2] https://lore.kernel.org/netdev/20200306010602.1620354-1-kuba@kernel.org/

Jakub Kicinski (15):
  net: ena: reject unsupported coalescing params
  net: aquantia: reject all unsupported coalescing params
  net: systemport: reject unsupported coalescing params
  net: bnx2: reject unsupported coalescing params
  net: bnx2x: reject unsupported coalescing params
  net: bcmgenet: reject unsupported coalescing params
  net: tg3: reject unsupported coalescing params
  net: bna: reject unsupported coalescing params
  net: liquidio: reject unsupported coalescing params
  net: mlx4: reject unsupported coalescing params
  net: cxgb2: reject unsupported coalescing params
  net: cxgb3: reject unsupported coalescing params
  net: cxgb4: reject unsupported coalescing params
  net: cxgb4vf: reject unsupported coalescing params
  net: gemini: reject unsupported coalescing params

 drivers/net/ethernet/amazon/ena/ena_ethtool.c     |  2 ++
 .../net/ethernet/aquantia/atlantic/aq_ethtool.c   | 15 +++------------
 drivers/net/ethernet/broadcom/bcmsysport.c        |  6 ++++--
 drivers/net/ethernet/broadcom/bnx2.c              |  5 +++++
 .../net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c   |  1 +
 drivers/net/ethernet/broadcom/genet/bcmgenet.c    |  7 +++----
 drivers/net/ethernet/broadcom/tg3.c               |  5 +++++
 drivers/net/ethernet/brocade/bna/bnad_ethtool.c   |  3 +++
 .../net/ethernet/cavium/liquidio/lio_ethtool.c    | 11 +++++++++++
 drivers/net/ethernet/chelsio/cxgb/cxgb2.c         |  3 +++
 drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c   |  1 +
 .../net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c    |  4 ++++
 .../net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c   |  2 ++
 drivers/net/ethernet/cortina/gemini.c             |  2 ++
 drivers/net/ethernet/mellanox/mlx4/en_ethtool.c   |  4 ++++
 include/linux/ethtool.h                           |  5 +++++
 16 files changed, 58 insertions(+), 18 deletions(-)

Comments

David Miller March 10, 2020, 2:43 a.m. UTC | #1 
From: Jakub Kicinski <kuba@kernel.org>
Date: Mon,  9 Mar 2020 19:14:57 -0700

> Convert more drivers following the groundwork laid in a recent
> patch set [1] and continued in [2]. The aim of the effort is to
> consolidate irq coalescing parameter validation in the core.
> 
> This set converts 15 drivers in drivers/net/ethernet.
> 3 more conversion sets to come.
> 
> None of the drivers here checked all unsupported parameters.
> 
> [1] https://lore.kernel.org/netdev/20200305051542.991898-1-kuba@kernel.org/
> [2] https://lore.kernel.org/netdev/20200306010602.1620354-1-kuba@kernel.org/

I'll let this sit for a day for review(s).
Jakub Kicinski March 10, 2020, 3:05 a.m. UTC | #2 
On Mon, 09 Mar 2020 19:43:13 -0700 (PDT) David Miller wrote:
> From: Jakub Kicinski <kuba@kernel.org>
> Date: Mon,  9 Mar 2020 19:14:57 -0700
> 
> > Convert more drivers following the groundwork laid in a recent
> > patch set [1] and continued in [2]. The aim of the effort is to
> > consolidate irq coalescing parameter validation in the core.
> > 
> > This set converts 15 drivers in drivers/net/ethernet.
> > 3 more conversion sets to come.
> > 
> > None of the drivers here checked all unsupported parameters.
> > 
> > [1] https://lore.kernel.org/netdev/20200305051542.991898-1-kuba@kernel.org/
> > [2] https://lore.kernel.org/netdev/20200306010602.1620354-1-kuba@kernel.org/  
> 
> I'll let this sit for a day for review(s).

Makes sense, this is partially manual work, good to have it double
checked by folks.
David Miller March 10, 2020, 11:29 p.m. UTC | #3 
From: Jakub Kicinski <kuba@kernel.org>
Date: Mon,  9 Mar 2020 19:14:57 -0700

> Convert more drivers following the groundwork laid in a recent
> patch set [1] and continued in [2]. The aim of the effort is to
> consolidate irq coalescing parameter validation in the core.
> 
> This set converts 15 drivers in drivers/net/ethernet.
> 3 more conversion sets to come.
> 
> None of the drivers here checked all unsupported parameters.
> 
> [1] https://lore.kernel.org/netdev/20200305051542.991898-1-kuba@kernel.org/
> [2] https://lore.kernel.org/netdev/20200306010602.1620354-1-kuba@kernel.org/

Series applied, thank you.