| Message ID | 20191211154536.5701-1-tariqt@mellanox.com |
|---|---|
| Headers | show |
| Series | Devlink health reporter's issues | expand |
On Wed, 11 Dec 2019 17:45:33 +0200 Tariq Toukan <tariqt@mellanox.com> wrote: > Hi, > > This patchset by Aya fixes two issues: wrong time-stamp on a dump in > devlink health reporter and messy display of non JSON output in devlink > health diagnostics and dump. > > 1) Wrong time-stamp on a dump in devlink health reporter: > This bug fix consist of 2 patches. First patch refactors the current > implementation of helper function which displays the reporter's dump > time-stamp and add the actual print to the function's body. > The second patch introduces a new attribute which is the time-stamp in > current time in nsec instead of jiffies. When the new attribute is > present try and translate the time-stamp according to 'current time'. > > 2) Messy display of non-JSON output in devlink health diagnostics and dump: > This patch mainly deals with dynamic object and array opening. The > label is stored and only when the proceeding value arrives the name is > printed with regards to the context. > > Series generated against the shared master/net-next head: > 24bee3bf9752 tipc: add new commands to set TIPC AEAD key > > Regards, > Tariq > > Aya Levin (3): > devlink: Print health reporter's dump time-stamp in a helper function > devlink: Add a new time-stamp format for health reporter's dump > devlink: Fix fmsg nesting in non JSON output > > devlink/devlink.c | 153 +++++++++++++++++++++++++++++++++++----------- > 1 file changed, 119 insertions(+), 34 deletions(-) > Applied, devlink really needs to get converted to same json library as rest of iproute2.
On 12/16/19 9:53 PM, Stephen Hemminger wrote: > Applied, devlink really needs to get converted to same json > library as rest of iproute2. We have been saying that for too many releases. rdma has fixed its json support; devlink needs to the same. Maybe it is time to stop taking patches.
On Tue, 17 Dec 2019 08:08:31 -0700 David Ahern <dsahern@gmail.com> wrote: > On 12/16/19 9:53 PM, Stephen Hemminger wrote: > > Applied, devlink really needs to get converted to same json > > library as rest of iproute2. > > We have been saying that for too many releases. rdma has fixed its json > support; devlink needs to the same. > > Maybe it is time to stop taking patches. Or add nagware patch :-)
Tue, Dec 17, 2019 at 04:08:31PM CET, dsahern@gmail.com wrote: >On 12/16/19 9:53 PM, Stephen Hemminger wrote: >> Applied, devlink really needs to get converted to same json >> library as rest of iproute2. > >We have been saying that for too many releases. rdma has fixed its json >support; devlink needs to the same. It's under work now, patches are going to be sent soon, hopefully. > >Maybe it is time to stop taking patches.