| Message ID | 20191101030700.13080-1-jakub.kicinski@netronome.com |
|---|---|
| Headers | show |
| Series | fix BPF offload related bugs | expand |
On 11/1/19 4:06 AM, Jakub Kicinski wrote: > Hi! > > test_offload.py catches some recently added bugs. > > First of a bug in test_offload.py itself after recent changes > to netdevsim is fixed. > > Second patch fixes a bug in cls_bpf, and last one addresses > a problem with the recently added XDP installation optimization. > > Jakub Kicinski (3): > selftests: bpf: Skip write only files in debugfs > net: cls_bpf: fix NULL deref on offload filter removal > net: fix installing orphaned programs > > net/core/dev.c | 3 ++- > net/sched/cls_bpf.c | 8 ++++++-- > tools/testing/selftests/bpf/test_offload.py | 5 +++++ > 3 files changed, 13 insertions(+), 3 deletions(-) Should this go via -bpf or -net? Either way is fine, but asking given it's BPF related fixes; planning to do a PR in the evening, set looks good to me in any case. Thanks, Daniel
On Fri, 1 Nov 2019 13:10:13 +0100, Daniel Borkmann wrote: > On 11/1/19 4:06 AM, Jakub Kicinski wrote: > > Hi! > > > > test_offload.py catches some recently added bugs. > > > > First of a bug in test_offload.py itself after recent changes > > to netdevsim is fixed. > > > > Second patch fixes a bug in cls_bpf, and last one addresses > > a problem with the recently added XDP installation optimization. > > > > Jakub Kicinski (3): > > selftests: bpf: Skip write only files in debugfs > > net: cls_bpf: fix NULL deref on offload filter removal > > net: fix installing orphaned programs > > > > net/core/dev.c | 3 ++- > > net/sched/cls_bpf.c | 8 ++++++-- > > tools/testing/selftests/bpf/test_offload.py | 5 +++++ > > 3 files changed, 13 insertions(+), 3 deletions(-) > > Should this go via -bpf or -net? Either way is fine, but asking > given it's BPF related fixes; planning to do a PR in the evening, > set looks good to me in any case. FWIW I'm fine either way, too. I made it net after Alexei wondered if we should apply the revert to net-next, but since you took the revert to bpf-next perhaps bpf makes sense. To state the obvious the only thing that matters is for the revert to be in net-next when these are merged into net-next (IOW bpf-next PR is what matters most at this point ;)).
From: Jakub Kicinski <jakub.kicinski@netronome.com> Date: Thu, 31 Oct 2019 20:06:57 -0700 > test_offload.py catches some recently added bugs. > > First of a bug in test_offload.py itself after recent changes > to netdevsim is fixed. > > Second patch fixes a bug in cls_bpf, and last one addresses > a problem with the recently added XDP installation optimization. Series applied and queued up for -stable.