mbox series

[v5,0/5] SCTP: Event skb list overhaul.

Message ID 20190410.141922.1900802525394998405.davem@davemloft.net
Headers show
Series SCTP: Event skb list overhaul. | expand

Message

David Miller April 10, 2019, 9:19 p.m. UTC
This patch series eliminates the explicit reference to the skb list
implementation via skb->prev dereferences.

The approach used is to pass a non-empty skb list around instead of an
event skb object which may or may not be on a list.

I'd like to thank Marcelo Leitner, Xin Long, and Neil Horman for
reviewing previous versions of this series.

Testing would be very much appreciated, in addition to the review of
course.

v4 --> v5: Rebase to net-next and remove RFC tag

v3 --> v4: Fix the logic in patch #4 so that we don't miss cases
           where we should add event to the on-stack temp list.
    
Signed-off-by: David S. Miller <davem@davemloft.net>

Comments

David Miller April 11, 2019, 9:39 p.m. UTC | #1
From: David Miller <davem@davemloft.net>
Date: Wed, 10 Apr 2019 14:19:22 -0700 (PDT)

> This patch series eliminates the explicit reference to the skb list
> implementation via skb->prev dereferences.
 ...

Can I get some ACKs etc. before I toss this into net-next?

It's the same as the v4, just respun to current net-next.
Marcelo Ricardo Leitner April 11, 2019, 9:54 p.m. UTC | #2
On Thu, Apr 11, 2019 at 02:39:35PM -0700, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Wed, 10 Apr 2019 14:19:22 -0700 (PDT)
> 
> > This patch series eliminates the explicit reference to the skb list
> > implementation via skb->prev dereferences.
>  ...
> 
> Can I get some ACKs etc. before I toss this into net-next?
> 
> It's the same as the v4, just respun to current net-next.

Yep, but I never got the v5 series. This is the first indication that
I have of its existence. Need a repost here.

  Marcelo
David Miller April 11, 2019, 9:58 p.m. UTC | #3
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Date: Thu, 11 Apr 2019 18:54:13 -0300

> On Thu, Apr 11, 2019 at 02:39:35PM -0700, David Miller wrote:
>> From: David Miller <davem@davemloft.net>
>> Date: Wed, 10 Apr 2019 14:19:22 -0700 (PDT)
>> 
>> > This patch series eliminates the explicit reference to the skb list
>> > implementation via skb->prev dereferences.
>>  ...
>> 
>> Can I get some ACKs etc. before I toss this into net-next?
>> 
>> It's the same as the v4, just respun to current net-next.
> 
> Yep, but I never got the v5 series. This is the first indication that
> I have of its existence. Need a repost here.

It was posted to netdev but I forgot to CC: you guys, sorry.

I'll repost.