From patchwork Thu Feb 28 18:38:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 1049695 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=networkplumber.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="Qe8YrSoa"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 449LsM20Vqz9s4Z for ; Fri, 1 Mar 2019 05:38:15 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733140AbfB1SiN (ORCPT ); Thu, 28 Feb 2019 13:38:13 -0500 Received: from mail-pg1-f174.google.com ([209.85.215.174]:46568 "EHLO mail-pg1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727649AbfB1SiN (ORCPT ); Thu, 28 Feb 2019 13:38:13 -0500 Received: by mail-pg1-f174.google.com with SMTP id 196so10116724pgf.13 for ; Thu, 28 Feb 2019 10:38:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=YoabfHgUWd34Ixg/1U/PYgLbuSD9fpbnqCeHTqbZv4s=; b=Qe8YrSoaTLrAu+Qjl1pk1a8X1C14n2HgouBgmVXdqFQSy6RLLbNXi9zkaCgRQJscZ7 RPQIK2W/CuqeRoW6PkvybDp8HajmwGqYx/9DRIL85sV7X6RH+31FmaP8tRB+GYJO0gEH j1YgoftjYg/cXRFPuaO6vlYyWazWu2iAV0KaaSRrfB48kHBMXGjz9zQYwto0lq00mvpf sI7F64lJBV7bbC2ZDtLo8u9M9wgP5iIi+O5pkSKoCKmG4MwntfB4PpceqA0PsgNi+/we LoC/Kns6oV8aT8ZHIolXSEQnteORYLNa1528PqXe0YbtRHqpEC1f3te1F5HPVAdiHy3y tLoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=YoabfHgUWd34Ixg/1U/PYgLbuSD9fpbnqCeHTqbZv4s=; b=XtVJdnBhnHbVO6/akHOKNjnvg8jZM2l6WkeGBY1o5Q7pWo3gb2bv6O8UjYIAENOEJH eL1q2ujcuCAmiho5Ng2x53YW1QAUF8/m/5a1yGsKxt4VSMI2sJHSUo9pA29vj+QDkjpI /4uhbMS65mxAWPJGMqmEg7GAZ/TxSbbELtq8z3dEbx3nNbxREbkbBlGXeN8PvwbdvuqN IrjhkfSTo/e+4NNjlnBDpDZhjGhg0cOIdi8+Op2j+0xOnIJNy1njdA+MYS1AnDF/tlnB mp0Rkre1M9imU32il6WNV/SZWAHFqz8pi9QBQydpzNIviLJY6mzyPwC7ZEJ70HUuBYR0 W9iA== X-Gm-Message-State: APjAAAUQAeftku/9fz98tSTCVl2rrXohrkoCqOG4xDWlpwRwqmmXG+aE dyRdjPszT28M50PvZZnLWfGyAG0L6+0= X-Google-Smtp-Source: AHgI3IaW5qcaF6nuDnImIu4A1QR4ZnO+ubo77UwGaY7xqOU9k6N37Bzr7oEazkYKk5qHPFnmB/Spug== X-Received: by 2002:a62:138f:: with SMTP id 15mr967189pft.219.1551379092472; Thu, 28 Feb 2019 10:38:12 -0800 (PST) Received: from shemminger-XPS-13-9360.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id c10sm25262702pfo.19.2019.02.28.10.38.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Feb 2019 10:38:11 -0800 (PST) From: Stephen Hemminger X-Google-Original-From: Stephen Hemminger To: netdev@vger.kernel.org Cc: Stephen Hemminger Subject: [RFC 0/7] ndo_bpf error reporting Date: Thu, 28 Feb 2019 10:38:03 -0800 Message-Id: <20190228183809.25417-1-sthemmin@microsoft.com> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Several drivers are logging errors to console rather than using xdp->extack to report problems. Try and make user experience consistent. Note: these patches are RFC because compile tested only. Stephen Hemminger (6): bnxt: use extack for xdp error messages ixgbe: use extack for xdp errors i40e: use extack for bpf errors ixgebvf: report xdp errors through extack mlx4: report errors through extack mlx5: report XDP errors through extack drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 26 +++++++++---------- drivers/net/ethernet/intel/i40e/i40e_main.c | 14 +++++++--- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 25 +++++++++++++----- .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 11 +++++--- .../net/ethernet/mellanox/mlx4/en_netdev.c | 14 ++++++---- .../net/ethernet/mellanox/mlx5/core/en_main.c | 22 +++++++++------- 6 files changed, 71 insertions(+), 41 deletions(-)