mbox series

[net-next,0/5] nfp: control processor DMA support and RJ45

Message ID 20190227041933.15194-1-jakub.kicinski@netronome.com
Headers show
Series nfp: control processor DMA support and RJ45 | expand

Message

Jakub Kicinski Feb. 27, 2019, 4:19 a.m. UTC 
Hi!

This series starts with adding support for reporting twisted pair
media type in ethtool.

Remaining patches add support for using DMA with the control/service
processor.  Currently we always copy the command data into card's
memory.  DMA support allows us to have the NSP read the data from
host memory by itself.  Unfortunately, the FW loading and flashing
cannot directly map the buffers for DMA because (a) the firmware
ABI returns const buffers, and (b) the buffers may be vmalloc()ed
in many mysterious/unmappable way.  So just bite the bullet -
allocate new host buffer for the command and copy.

As Dirk explains, the NSP now supports updating all FWs at once
which means the max flashing time grew significantly.  He bumps
the max wait to avoid timeouts.

Dirk van der Merwe (1):
  nfp: nsp: set higher timeout for flash bundle

Jakub Kicinski (4):
  nfp: report RJ45 connector in ethtool
  nfp: nsp: use fractional size of the buffer
  nfp: nsp: move default buffer handling into its own function
  nfp: nsp: allow the use of DMA buffer

 .../ethernet/netronome/nfp/nfpcore/nfp_nsp.c  | 285 +++++++++++++++---
 .../ethernet/netronome/nfp/nfpcore/nfp_nsp.h  |   1 +
 .../netronome/nfp/nfpcore/nfp_nsp_eth.c       |   3 +
 3 files changed, 243 insertions(+), 46 deletions(-)

Comments

David Miller March 1, 2019, 8 p.m. UTC | #1 
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Tue, 26 Feb 2019 20:19:28 -0800

> This series starts with adding support for reporting twisted pair
> media type in ethtool.
> 
> Remaining patches add support for using DMA with the control/service
> processor.  Currently we always copy the command data into card's
> memory.  DMA support allows us to have the NSP read the data from
> host memory by itself.  Unfortunately, the FW loading and flashing
> cannot directly map the buffers for DMA because (a) the firmware
> ABI returns const buffers, and (b) the buffers may be vmalloc()ed
> in many mysterious/unmappable way.  So just bite the bullet -
> allocate new host buffer for the command and copy.
> 
> As Dirk explains, the NSP now supports updating all FWs at once
> which means the max flashing time grew significantly.  He bumps
> the max wait to avoid timeouts.

Series applied, thanks Jakub.