From patchwork Tue Jan 15 18:53:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Song Liu X-Patchwork-Id: 1025372 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=fb.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=fb.com header.i=@fb.com header.b="Jh13oG6S"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43fKK3022Tz9s9G for ; Wed, 16 Jan 2019 05:55:03 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388045AbfAOSx4 (ORCPT ); Tue, 15 Jan 2019 13:53:56 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:54466 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728549AbfAOSx4 (ORCPT ); Tue, 15 Jan 2019 13:53:56 -0500 Received: from pps.filterd (m0109331.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x0FIqZgV029685 for ; Tue, 15 Jan 2019 10:53:54 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=facebook; bh=JZcXAYnkH09xxcSFnCnjHgHxKrY5GJ0xLATiPzFeWKI=; b=Jh13oG6SKwkDNyVWl+uC2lOBjpsuwYMqeM1M/8uFN/AHU2kCR8Ss2U/8noJL4IyMDhXD 5o4PC1pC6tFkiRW+mMsgy6lsf2vbEBT754nwijmdhAIU2pe93TT4J+I8dvXtlY/Jr2wT hBkKlocR3mU7scu8vuJ5xZN2C9QrGodfA38= Received: from maileast.thefacebook.com ([199.201.65.23]) by mx0a-00082601.pphosted.com with ESMTP id 2q1jfb8sny-5 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Tue, 15 Jan 2019 10:53:54 -0800 Received: from mx-out.facebook.com (2620:10d:c0a1:3::13) by mail.thefacebook.com (2620:10d:c021:18::176) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.1.1531.3; Tue, 15 Jan 2019 10:53:52 -0800 Received: by devbig006.ftw2.facebook.com (Postfix, from userid 4523) id 615C362E102C; Tue, 15 Jan 2019 10:53:51 -0800 (PST) Smtp-Origin-Hostprefix: devbig From: Song Liu Smtp-Origin-Hostname: devbig006.ftw2.facebook.com To: , CC: Song Liu , , , , , , Smtp-Origin-Cluster: ftw2c04 Subject: [PATCH v8 perf, bpf-next 0/9] reveal invisible bpf programs Date: Tue, 15 Jan 2019 10:53:40 -0800 Message-ID: <20190115185349.1191609-1-songliubraving@fb.com> X-Mailer: git-send-email 2.17.1 X-FB-Internal: Safe MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-01-15_06:, , signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This set catches symbol for all bpf programs loaded/unloaded before/during/after perf-record run PERF_RECORD_KSYMBOL and PERF_RECORD_BPF_EVENT. PERF_RECORD_KSYMBOL and PERF_RECORD_BPF_EVENT includes key information of a bpf program load and unload. They are sent through perf ringbuffer, and stored in perf.data. PERF_RECORD_KSYMBOL includes basic information for simple profiling. It is ON by default. PERF_RECORD_BPF_EVENT is used to gather more information of the bpf program. It is necessary for perf-annotate of bpf programs. Before this patch, perf-report will not be able to recover symbols of bpf programs once the programs are unloaded. This is to follow up Alexei's early effort [2] to show bpf programs via mmap events. Thanks, Song Changes v7 -> PATCH v8: 1. Fixed perf dump_stack to use stdout instead of stderr; 2. Added module name [bpf] to /proc/kallsyms (9/9); 3. Do not show warning "Couldn't synthesize bpf events." when the kernel does not support proper sys_bpf call; 4. Added Arnaldo's patch that synthesizes BPF events in perf-top. Changes v6 -> PATCH v7: 1. Split "[3/7] introduce PERF_RECORD_BPF_EVENT" into two commits: [3/8] introduce PERF_RECORD_BPF_EVENT [5/8] emit PERF_RECORD_KSYMBOL for BPF program load/unload Changes v5 -> PATCH v6: 1. Reduce len in PERF_RECORD_KSYMBOL from u64 to u32. Use the 32 free bits for ksym_type (u16) and flags (u16). Changes v4 -> PATCH v5: 1. Fixed build error reported by kbuild test bot. Changes v3 -> PATCH v4: 1. Split information about bpf program into PERF_RECORD_KSYMBOL (with name, addr, len); and PERF_RECORD_BPF_EVENT PERF_RECORD_BPF_EVENT (with id, tag); 2. Split the implementation in kernel and user space. Changes v2 -> PATCH v3: 1. Rebase on bpf-next tree, and on top of BPF sub program tag patches [1] for latest information in bpf_prog_info. 2. Complete handling and synthesizing PERF_RECORD_BPF_EVENT in perf. Changes v1 -> PATCH v2: 1. Only 3 of the 5 patches in v1, to focus on ABI first; 2. Generate PERF_RECORD_BPF_EVENT per bpf sub program instead of per prog; 3. Modify PERF_RECORD_BPF_EVENT with more details (addr, len, name), so that it can be used for basic profiling without calling sys_bpf. Changes RFC -> PATCH v1: 1. In perf-record, poll vip events in a separate thread; 2. Add tag to bpf prog name; 3. Small refactorings. [1] https://patchwork.ozlabs.org/project/netdev/list/?series=81037 [2] https://www.spinics.net/lists/netdev/msg524232.html Arnaldo Carvalho de Melo (1): perf top: Synthesize BPF events for pre-existing loaded BPF programs Song Liu (8): perf, bpf: Introduce PERF_RECORD_KSYMBOL sync tools/include/uapi/linux/perf_event.h perf, bpf: introduce PERF_RECORD_BPF_EVENT sync tools/include/uapi/linux/perf_event.h perf util: handle PERF_RECORD_KSYMBOL perf util: handle PERF_RECORD_BPF_EVENT perf tools: synthesize PERF_RECORD_* for loaded BPF programs bpf: add module name [bpf] to ksymbols for bpf programs include/linux/filter.h | 7 + include/linux/perf_event.h | 19 +++ include/uapi/linux/perf_event.h | 53 +++++- kernel/bpf/core.c | 2 +- kernel/bpf/syscall.c | 2 + kernel/events/core.c | 218 ++++++++++++++++++++++++- kernel/kallsyms.c | 2 +- tools/include/uapi/linux/perf_event.h | 53 +++++- tools/perf/builtin-record.c | 7 + tools/perf/builtin-top.c | 7 + tools/perf/perf.h | 1 + tools/perf/util/Build | 2 + tools/perf/util/bpf-event.c | 221 ++++++++++++++++++++++++++ tools/perf/util/bpf-event.h | 16 ++ tools/perf/util/event.c | 41 +++++ tools/perf/util/event.h | 36 +++++ tools/perf/util/evsel.c | 19 +++ tools/perf/util/evsel.h | 2 + tools/perf/util/machine.c | 60 +++++++ tools/perf/util/machine.h | 3 + tools/perf/util/session.c | 8 + tools/perf/util/tool.h | 5 +- 22 files changed, 778 insertions(+), 6 deletions(-) create mode 100644 tools/perf/util/bpf-event.c create mode 100644 tools/perf/util/bpf-event.h --- 2.17.1