mbox series

[v2,0/3] sched: Fix qdisc interactions exposed by using sch_cake as a leaf qdisc

Message ID 20190109160943.18051-1-toke@redhat.com
Headers show
Series sched: Fix qdisc interactions exposed by using sch_cake as a leaf qdisc | expand

Message

Toke Høiland-Jørgensen Jan. 9, 2019, 4:09 p.m. UTC 
This series fixes a couple of issues exposed by running sch_cake as a
leaf qdisc in an HFSC tree, which were discovered and reported by Pete
Heist. The interaction between CAKE's GSO splitting and the parent
qdisc's notion of its own queue length could cause queue stalls. While
investigating the report, I also noticed that several qdiscs would
dereference the skb pointer after dequeue, which is potentially
problematic since the GSO splitting code also frees the original skb.

See the individual patches in the series for details.

Toke Høiland-Jørgensen (3):
  sched: Avoid dereferencing skb pointer after child enqueue
  sched: Fix detection of empty queues in child qdiscs
  sch_cake: Correctly update parent qlen when splitting GSO packets

 net/sched/sch_cake.c   |  5 +++--
 net/sched/sch_cbs.c    |  3 ++-
 net/sched/sch_drr.c    |  7 +++++--
 net/sched/sch_dsmark.c |  3 ++-
 net/sched/sch_hfsc.c   |  9 +++++----
 net/sched/sch_htb.c    |  3 ++-
 net/sched/sch_prio.c   |  3 ++-
 net/sched/sch_qfq.c    | 20 ++++++++++++--------
 net/sched/sch_tbf.c    |  3 ++-
 9 files changed, 35 insertions(+), 21 deletions(-)

Comments

David Miller Jan. 16, 2019, 4:12 a.m. UTC | #1 
From: Toke Høiland-Jørgensen <toke@redhat.com>
Date: Wed,  9 Jan 2019 17:09:40 +0100

> This series fixes a couple of issues exposed by running sch_cake as a
> leaf qdisc in an HFSC tree, which were discovered and reported by Pete
> Heist. The interaction between CAKE's GSO splitting and the parent
> qdisc's notion of its own queue length could cause queue stalls. While
> investigating the report, I also noticed that several qdiscs would
> dereference the skb pointer after dequeue, which is potentially
> problematic since the GSO splitting code also frees the original skb.
> 
> See the individual patches in the series for details.

Series applied.