mbox series

[iproute2,00/22] misc cleanups

Message ID 20181115223640.411-1-stephen@networkplumber.org
Headers show
Series misc cleanups | expand

Message

Stephen Hemminger Nov. 15, 2018, 10:36 p.m. UTC 
Code cleanup including:
   * make local functions static
   * drop dead code
   * whitespace code style cleanup

Stephen Hemminger (22):
  lib/ll_addr: whitespace and indent cleanup
  lib/utils: make local functions static
  lib/color: make local functions static
  lib/ll_map: make local function static
  libnetlnk: unused and local functions cleanup
  genl: remove dead code
  bridge: make local variables static
  ip: make flag names const/static
  ipmonitor: make local variable static
  ipxfrm: make local functions static
  tc: drop unused name_to_id function
  tipc: make cmd_find static
  tc/class: make filter variables static
  tc/police: make print_police static
  ss: make local variables static
  tc/pedit: make functions static
  tc/ematch: make local functions static
  tc/util: make local functions static
  tc/meta: make meta_table static and const
  tc/action: make variables static
  tc/pedit: use structure initialization
  rdma: make local functions static

 bridge/bridge.c      |  5 ++--
 bridge/monitor.c     |  2 +-
 genl/ctrl.c          | 71 --------------------------------------------
 genl/genl_utils.h    |  2 --
 include/color.h      |  2 --
 include/libnetlink.h |  7 -----
 include/ll_map.h     |  1 -
 include/names.h      |  1 -
 include/utils.h      |  5 ----
 ip/ipaddress.c       |  2 +-
 ip/ipmonitor.c       |  2 +-
 ip/ipxfrm.c          | 11 +++----
 ip/xfrm.h            |  9 ------
 ip/xfrm_monitor.c    |  2 +-
 lib/color.c          |  6 ++--
 lib/libnetlink.c     | 28 ++---------------
 lib/ll_addr.c        | 24 ++++++++-------
 lib/ll_map.c         |  2 +-
 lib/names.c          | 28 -----------------
 lib/utils.c          | 48 +++++-------------------------
 misc/ss.c            | 28 ++++++++---------
 rdma/rdma.h          | 11 -------
 rdma/utils.c         | 12 ++++----
 tc/em_meta.c         | 12 ++++----
 tc/m_action.c        |  4 +--
 tc/m_ematch.c        | 30 ++-----------------
 tc/m_ematch.h        |  1 -
 tc/m_pedit.c         | 33 +++++++++-----------
 tc/m_pedit.h         | 15 ----------
 tc/m_police.c        | 10 +++++--
 tc/p_eth.c           |  5 ++--
 tc/p_icmp.c          |  5 ++--
 tc/p_ip.c            |  5 ++--
 tc/p_ip6.c           |  5 ++--
 tc/p_tcp.c           |  5 ++--
 tc/p_udp.c           |  5 ++--
 tc/tc_class.c        |  6 ++--
 tc/tc_util.c         | 17 ++---------
 tc/tc_util.h         |  8 -----
 tipc/cmdl.c          |  2 +-
 tipc/cmdl.h          |  2 --
 41 files changed, 110 insertions(+), 369 deletions(-)

Comments

David Ahern Nov. 17, 2018, 11:19 p.m. UTC | #1 
On 11/15/18 3:36 PM, Stephen Hemminger wrote:
> Code cleanup including:
>    * make local functions static
>    * drop dead code
>    * whitespace code style cleanup
> 

Hi Stephen:

You did not mark these for -next but that is typically where cleanups
go. What is your intention?