mbox series

[bpf-next,0/3] sockmap support for msg_peek flag

Message ID 20181016180424.13607.7932.stgit@john-Precision-Tower-5810
Headers show
Series sockmap support for msg_peek flag | expand

Message

John Fastabend Oct. 16, 2018, 6:07 p.m. UTC
This adds support for the MSG_PEEK flag when redirecting into an
ingress psock sk_msg queue.

The first patch adds some base support to the helpers, then the
feature, and finally we add an option for the test suite to do
a duplicate MSG_PEEK call on every recv to test the feature.

With duplicate MSG_PEEK call all tests continue to PASS.

---

John Fastabend (3):
      bpf: skmsg, improve sk_msg_used_element to work in cork context
      bpf: sockmap, support for msg_peek in sk_msg with redirect ingress
      bpf: sockmap, add msg_peek tests to test_sockmap


 include/linux/skmsg.h                      |   13 +-
 include/net/tcp.h                          |    2 
 net/ipv4/tcp_bpf.c                         |   42 +++++--
 net/tls/tls_sw.c                           |    3 -
 tools/testing/selftests/bpf/test_sockmap.c |  167 +++++++++++++++++++---------
 5 files changed, 153 insertions(+), 74 deletions(-)

--
Signature

Comments

Alexei Starovoitov Oct. 16, 2018, 6:41 p.m. UTC | #1
On Tue, Oct 16, 2018 at 11:07:54AM -0700, John Fastabend wrote:
> This adds support for the MSG_PEEK flag when redirecting into an
> ingress psock sk_msg queue.
> 
> The first patch adds some base support to the helpers, then the
> feature, and finally we add an option for the test suite to do
> a duplicate MSG_PEEK call on every recv to test the feature.
> 
> With duplicate MSG_PEEK call all tests continue to PASS.

for the set
Acked-by: Alexei Starovoitov <ast@kernel.org>
Daniel Borkmann Oct. 17, 2018, 12:32 a.m. UTC | #2
On 10/16/2018 08:41 PM, Alexei Starovoitov wrote:
> On Tue, Oct 16, 2018 at 11:07:54AM -0700, John Fastabend wrote:
>> This adds support for the MSG_PEEK flag when redirecting into an
>> ingress psock sk_msg queue.
>>
>> The first patch adds some base support to the helpers, then the
>> feature, and finally we add an option for the test suite to do
>> a duplicate MSG_PEEK call on every recv to test the feature.
>>
>> With duplicate MSG_PEEK call all tests continue to PASS.
> 
> for the set
> Acked-by: Alexei Starovoitov <ast@kernel.org>

Applied to bpf-next, thanks!