mbox series

[bpf-next,0/8] AF_XDP follow-up patches, uapi and cleanups

Message ID 20180522073503.2199-1-bjorn.topel@gmail.com
Headers show
Series AF_XDP follow-up patches, uapi and cleanups | expand

Message

Björn Töpel May 22, 2018, 7:34 a.m. UTC
From: Björn Töpel <bjorn.topel@intel.com>

This the second follow-up set. The first four patches are uapi
changes:

* Removing rebind support
* Getting rid of structure hole
* Removing explicit cache line alignment
* Stricter bind checks

The last patches do some cleanups, where the umem and refcount_t
changes were suggested by Daniel.

* Add a missing write-barrier and use READ_ONCE for data-dependencies
* Clean up umem and do proper locking
* Convert atomic_t to refcount_t

Björn Töpel (7):
  xsk: remove rebind support
  xsk: fill hole in struct sockaddr_xdp
  xsk: remove explicit ring structure from uapi
  samples/bpf: adapt xdpsock to the new uapi
  xsk: add missing write- and data-dependency barrier
  xsk: simplified umem setup
  xsk: convert atomic_t to refcount_t

Magnus Karlsson (1):
  xsk: proper queue id check at bind

 include/uapi/linux/if_xdp.h |  46 ++++++++---------
 net/xdp/xdp_umem.c          |  85 +++++++++++++++---------------
 net/xdp/xdp_umem.h          |   5 +-
 net/xdp/xsk.c               | 105 +++++++++++++++++++++++--------------
 net/xdp/xsk_queue.h         |  17 ++++++
 samples/bpf/xdpsock_user.c  | 123 +++++++++++++++++++++++++++-----------------
 6 files changed, 225 insertions(+), 156 deletions(-)

Comments

Daniel Borkmann May 22, 2018, 8:59 a.m. UTC | #1
On 05/22/2018 09:34 AM, Björn Töpel wrote:
> From: Björn Töpel <bjorn.topel@intel.com>
> 
> This the second follow-up set. The first four patches are uapi
> changes:
> 
> * Removing rebind support
> * Getting rid of structure hole
> * Removing explicit cache line alignment
> * Stricter bind checks
> 
> The last patches do some cleanups, where the umem and refcount_t
> changes were suggested by Daniel.
> 
> * Add a missing write-barrier and use READ_ONCE for data-dependencies
> * Clean up umem and do proper locking
> * Convert atomic_t to refcount_t
> 
> Björn Töpel (7):
>   xsk: remove rebind support
>   xsk: fill hole in struct sockaddr_xdp
>   xsk: remove explicit ring structure from uapi
>   samples/bpf: adapt xdpsock to the new uapi
>   xsk: add missing write- and data-dependency barrier
>   xsk: simplified umem setup
>   xsk: convert atomic_t to refcount_t
> 
> Magnus Karlsson (1):
>   xsk: proper queue id check at bind
> 
>  include/uapi/linux/if_xdp.h |  46 ++++++++---------
>  net/xdp/xdp_umem.c          |  85 +++++++++++++++---------------
>  net/xdp/xdp_umem.h          |   5 +-
>  net/xdp/xsk.c               | 105 +++++++++++++++++++++++--------------
>  net/xdp/xsk_queue.h         |  17 ++++++
>  samples/bpf/xdpsock_user.c  | 123 +++++++++++++++++++++++++++-----------------
>  6 files changed, 225 insertions(+), 156 deletions(-)

LGTM, applied to bpf-next, thanks guys!