mbox series

[0/2] bpf: Change print_bpf_insn interface

Message ID 20180323104129.14989-1-jolsa@kernel.org
Headers show
Series bpf: Change print_bpf_insn interface | expand

Message

Jiri Olsa March 23, 2018, 10:41 a.m. UTC
hi,
this patchset removes struct bpf_verifier_env argument
from print_bpf_insn function (patch 1) and changes user
space bpftool user to use it that way (patch 2).

thanks,
jirka

---
Jiri Olsa (2):
      bpf: Remove struct bpf_verifier_env argument from print_bpf_insn
      bpftool: Adjust to new print_bpf_insn interface

 kernel/bpf/disasm.c               | 52 ++++++++++++++++++++++++++--------------------------
 kernel/bpf/disasm.h               |  5 +----
 kernel/bpf/verifier.c             | 44 +++++++++++++++++++++++++++-----------------
 tools/bpf/bpftool/xlated_dumper.c | 12 ++++++------
 4 files changed, 60 insertions(+), 53 deletions(-)

Comments

Quentin Monnet March 23, 2018, 1:34 p.m. UTC | #1
2018-03-23 11:41 UTC+0100 ~ Jiri Olsa <jolsa@kernel.org>
> hi,
> this patchset removes struct bpf_verifier_env argument
> from print_bpf_insn function (patch 1) and changes user
> space bpftool user to use it that way (patch 2).
> 
> thanks,
> jirka
> 
> ---
> Jiri Olsa (2):
>       bpf: Remove struct bpf_verifier_env argument from print_bpf_insn
>       bpftool: Adjust to new print_bpf_insn interface
> 
>  kernel/bpf/disasm.c               | 52 ++++++++++++++++++++++++++--------------------------
>  kernel/bpf/disasm.h               |  5 +----
>  kernel/bpf/verifier.c             | 44 +++++++++++++++++++++++++++-----------------
>  tools/bpf/bpftool/xlated_dumper.c | 12 ++++++------
>  4 files changed, 60 insertions(+), 53 deletions(-)
> 

Thanks, this version looks good to me. Please keep the "Reviewed-by"
tags when resubmitting new versions of your patch sets :)

For the series:
Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
Daniel Borkmann March 23, 2018, 4:47 p.m. UTC | #2
On 03/23/2018 02:34 PM, Quentin Monnet wrote:
> 2018-03-23 11:41 UTC+0100 ~ Jiri Olsa <jolsa@kernel.org>
>> hi,
>> this patchset removes struct bpf_verifier_env argument
>> from print_bpf_insn function (patch 1) and changes user
>> space bpftool user to use it that way (patch 2).
>>
>> thanks,
>> jirka
>>
>> ---
>> Jiri Olsa (2):
>>       bpf: Remove struct bpf_verifier_env argument from print_bpf_insn
>>       bpftool: Adjust to new print_bpf_insn interface
>>
>>  kernel/bpf/disasm.c               | 52 ++++++++++++++++++++++++++--------------------------
>>  kernel/bpf/disasm.h               |  5 +----
>>  kernel/bpf/verifier.c             | 44 +++++++++++++++++++++++++++-----------------
>>  tools/bpf/bpftool/xlated_dumper.c | 12 ++++++------
>>  4 files changed, 60 insertions(+), 53 deletions(-)
>>
> 
> Thanks, this version looks good to me. Please keep the "Reviewed-by"
> tags when resubmitting new versions of your patch sets :)
> 
> For the series:
> Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>

Applied to bpf-next, thanks everyone!