| Message ID | 20171207174332.17689-1-ncardwell@google.com |
|---|---|
| Headers | show |
| Series | TCP BBR sampling fixes for loss recovery undo | expand |
On Thu, Dec 7, 2017 at 12:43 PM, Neal Cardwell <ncardwell@google.com> wrote: > This patch series has a few minor bug fixes for cases where spurious > loss recoveries can trick BBR estimators into estimating that the > available bandwidth is much lower than the true available bandwidth. > In both cases the fix here is to just reset the estimator upon loss > recovery undo. > > Neal Cardwell (3): > tcp_bbr: record "full bw reached" decision in new full_bw_reached bit > tcp_bbr: reset full pipe detection on loss recovery undo > tcp_bbr: reset long-term bandwidth sampling on loss recovery undo > > net/ipv4/tcp_bbr.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) Sorry, I should have mentioned these patches are all stable candidates and should have all carried a footer of: Fixes: 0f8782ea1497 ("tcp_bbr: add BBR congestion control") David, I can resend a v2 with that footer on each patch if you want. neal
From: Neal Cardwell <ncardwell@google.com> Date: Thu, 7 Dec 2017 12:48:40 -0500 > On Thu, Dec 7, 2017 at 12:43 PM, Neal Cardwell <ncardwell@google.com> wrote: >> This patch series has a few minor bug fixes for cases where spurious >> loss recoveries can trick BBR estimators into estimating that the >> available bandwidth is much lower than the true available bandwidth. >> In both cases the fix here is to just reset the estimator upon loss >> recovery undo. >> >> Neal Cardwell (3): >> tcp_bbr: record "full bw reached" decision in new full_bw_reached bit >> tcp_bbr: reset full pipe detection on loss recovery undo >> tcp_bbr: reset long-term bandwidth sampling on loss recovery undo >> >> net/ipv4/tcp_bbr.c | 12 ++++++++++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) > > Sorry, I should have mentioned these patches are all stable candidates > and should have all carried a footer of: > > Fixes: 0f8782ea1497 ("tcp_bbr: add BBR congestion control") > > David, I can resend a v2 with that footer on each patch if you want. It is not necessary to resend. Thanks.
From: Neal Cardwell <ncardwell@google.com> Date: Thu, 7 Dec 2017 12:43:29 -0500 > This patch series has a few minor bug fixes for cases where spurious > loss recoveries can trick BBR estimators into estimating that the > available bandwidth is much lower than the true available bandwidth. > In both cases the fix here is to just reset the estimator upon loss > recovery undo. Series applied and queued up for -stable, thanks Neal.