| Message ID | 1605829116-10056-1-git-send-email-wenxu@ucloud.cn |
|---|---|
| Headers | show |
| Series | net/sched: fix over mtu packet of defrag in | expand |
On Thu, Nov 19, 2020 at 3:39 PM <wenxu@ucloud.cn> wrote: > > From: wenxu <wenxu@ucloud.cn> > > Currently kernel tc subsystem can do conntrack in act_ct. But when several > fragment packets go through the act_ct, function tcf_ct_handle_fragments > will defrag the packets to a big one. But the last action will redirect > mirred to a device which maybe lead the reassembly big packet over the mtu > of target device. > > The first patch fix miss init the qdisc_skb_cb->mru > The send one refactor the hanle of xmit in act_mirred and prepare for the > third one > The last one add implict packet fragment support to fix the over mtu for > defrag in act_ct. Overall it looks much better to me now, so: Acked-by: Cong Wang <cong.wang@bytedance.com> Thanks!
On 2020-11-20 2:28 p.m., Cong Wang wrote: > On Thu, Nov 19, 2020 at 3:39 PM <wenxu@ucloud.cn> wrote: >> >> From: wenxu <wenxu@ucloud.cn> >> >> Currently kernel tc subsystem can do conntrack in act_ct. But when several >> fragment packets go through the act_ct, function tcf_ct_handle_fragments >> will defrag the packets to a big one. But the last action will redirect >> mirred to a device which maybe lead the reassembly big packet over the mtu >> of target device. >> >> The first patch fix miss init the qdisc_skb_cb->mru >> The send one refactor the hanle of xmit in act_mirred and prepare for the >> third one >> The last one add implict packet fragment support to fix the over mtu for >> defrag in act_ct. > > Overall it looks much better to me now, so: > > Acked-by: Cong Wang <cong.wang@bytedance.com> LGTM as well. Acked-by: Jamal Hadi Salim <jhs@mojatatu.com> cheers, jamal
From: wenxu <wenxu@ucloud.cn> Currently kernel tc subsystem can do conntrack in act_ct. But when several fragment packets go through the act_ct, function tcf_ct_handle_fragments will defrag the packets to a big one. But the last action will redirect mirred to a device which maybe lead the reassembly big packet over the mtu of target device. The first patch fix miss init the qdisc_skb_cb->mru The send one refactor the hanle of xmit in act_mirred and prepare for the third one The last one add implict packet fragment support to fix the over mtu for defrag in act_ct. wenxu (3): net/sched: fix miss init the mru in qdisc_skb_cb net/sched: act_mirred: refactor the handle of xmit net/sched: sch_frag: add generic packet fragment support. include/net/act_api.h | 8 +++ include/net/sch_generic.h | 5 +- net/core/dev.c | 2 + net/sched/Makefile | 1 + net/sched/act_api.c | 44 ++++++++++++++ net/sched/act_ct.c | 7 +++ net/sched/act_mirred.c | 21 +++++-- net/sched/sch_frag.c | 150 ++++++++++++++++++++++++++++++++++++++++++++++ 8 files changed, 228 insertions(+), 10 deletions(-) create mode 100644 net/sched/sch_frag.c