| Message ID | 160443914296.1086697.4231574770375103169.stgit@localhost.localdomain |
|---|---|
| Headers | show |
| Series | selftests/bpf: Migrate test_tcpbpf_user to be a part of test_progs framework | expand |
On Tue, Nov 03, 2020 at 01:34:40PM -0800, Alexander Duyck wrote: > Move the test functionality from test_tcpbpf_user into the test_progs > framework so that it will be run any time the test_progs framework is run. > This will help to prevent future test escapes as the individual tests, such > as test_tcpbpf_user, are less likely to be run by developers and CI > tests. > > As a part of moving it over the series goes through and updates the code to > make use of the existing APIs included in the test_progs framework. This is > meant to simplify and streamline the test code and avoid duplication of > effort. > > v2: Dropped test_tcpbpf_user from .gitignore > Replaced CHECK_FAIL calls with CHECK calls > Minimized changes in patch 1 when moving the file > Updated stg mail command line to display renames in submission > Added shutdown logic to end of run_test function to guarantee close > Added patch that replaces the two maps with use of global variables > v3: Left err at -1 while we are performing send/recv calls w/ data > Drop extra labels from test_tcpbpf_user in favor of keeping err label > Dropped redundant zero init for tcpbpf_globals result and key > Dropped replacing of "printf(" with "fprintf(stderr, " > Fixed error in use of ASSERT_OK_PTR which was skipping of run_test > Replaced "{ 0 }" with "{}" in init of global in test_tcpbpf_kern.c > Added "Acked-by" from Martin KaiFai Lau and Andrii Nakryiko Acked-by: Martin KaFai Lau <kafai@fb.com>
On Tue, Nov 3, 2020 at 4:20 PM Martin KaFai Lau <kafai@fb.com> wrote: > > On Tue, Nov 03, 2020 at 01:34:40PM -0800, Alexander Duyck wrote: > > Move the test functionality from test_tcpbpf_user into the test_progs > > framework so that it will be run any time the test_progs framework is run. > > This will help to prevent future test escapes as the individual tests, such > > as test_tcpbpf_user, are less likely to be run by developers and CI > > tests. > > > > As a part of moving it over the series goes through and updates the code to > > make use of the existing APIs included in the test_progs framework. This is > > meant to simplify and streamline the test code and avoid duplication of > > effort. > > > > v2: Dropped test_tcpbpf_user from .gitignore > > Replaced CHECK_FAIL calls with CHECK calls > > Minimized changes in patch 1 when moving the file > > Updated stg mail command line to display renames in submission > > Added shutdown logic to end of run_test function to guarantee close > > Added patch that replaces the two maps with use of global variables > > v3: Left err at -1 while we are performing send/recv calls w/ data > > Drop extra labels from test_tcpbpf_user in favor of keeping err label > > Dropped redundant zero init for tcpbpf_globals result and key > > Dropped replacing of "printf(" with "fprintf(stderr, " > > Fixed error in use of ASSERT_OK_PTR which was skipping of run_test > > Replaced "{ 0 }" with "{}" in init of global in test_tcpbpf_kern.c > > Added "Acked-by" from Martin KaiFai Lau and Andrii Nakryiko > Acked-by: Martin KaFai Lau <kafai@fb.com> Applied. Thanks
Move the test functionality from test_tcpbpf_user into the test_progs framework so that it will be run any time the test_progs framework is run. This will help to prevent future test escapes as the individual tests, such as test_tcpbpf_user, are less likely to be run by developers and CI tests. As a part of moving it over the series goes through and updates the code to make use of the existing APIs included in the test_progs framework. This is meant to simplify and streamline the test code and avoid duplication of effort. v2: Dropped test_tcpbpf_user from .gitignore Replaced CHECK_FAIL calls with CHECK calls Minimized changes in patch 1 when moving the file Updated stg mail command line to display renames in submission Added shutdown logic to end of run_test function to guarantee close Added patch that replaces the two maps with use of global variables v3: Left err at -1 while we are performing send/recv calls w/ data Drop extra labels from test_tcpbpf_user in favor of keeping err label Dropped redundant zero init for tcpbpf_globals result and key Dropped replacing of "printf(" with "fprintf(stderr, " Fixed error in use of ASSERT_OK_PTR which was skipping of run_test Replaced "{ 0 }" with "{}" in init of global in test_tcpbpf_kern.c Added "Acked-by" from Martin KaiFai Lau and Andrii Nakryiko --- Alexander Duyck (5): selftests/bpf: Move test_tcppbf_user into test_progs selftests/bpf: Drop python client/server in favor of threads selftests/bpf: Replace EXPECT_EQ with ASSERT_EQ and refactor verify_results selftests/bpf: Migrate tcpbpf_user.c to use BPF skeleton selftest/bpf: Use global variables instead of maps for test_tcpbpf_kern .../selftests/bpf/prog_tests/tcpbpf_user.c | 226 +++++++++--------- .../selftests/bpf/progs/test_tcpbpf_kern.c | 86 +------ tools/testing/selftests/bpf/tcp_client.py | 50 ---- tools/testing/selftests/bpf/tcp_server.py | 80 ------- tools/testing/selftests/bpf/test_tcpbpf.h | 2 + 5 files changed, 128 insertions(+), 316 deletions(-) delete mode 100755 tools/testing/selftests/bpf/tcp_client.py delete mode 100755 tools/testing/selftests/bpf/tcp_server.py --