| Message ID | 1562340622-4423-1-git-send-email-tariqt@mellanox.com |
|---|---|
| Headers | show |
| Series | mlx5 TLS TX HW offload support | expand |
On Fri, 5 Jul 2019 18:30:10 +0300, Tariq Toukan wrote: > Hi Dave, > > This series from Eran and me, adds TLS TX HW offload support to > the mlx5 driver. > > This offloads the kTLS encryption process from kernel to the > Mellanox NIC, saving CPU cycles and improving utilization. > > Upon a new TLS connection request, driver is responsible to create > a dedicated HW context and configure it according to the crypto info, > so HW can do the encryption itself. > > When the HW context gets out-of-sync (i.e. due to packets retransmission), > driver is responsible for the re-sync process. > This is done by posting special resync descriptors to the HW. > > Feature is supported on Mellanox Connect-X 6DX, and newer. > Series was tested on SimX simulator. > > Series generated against net-next commit [1], with Saeed's request pulled [2]: > > [1] c4cde5804d51 Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next > [2] git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git tags/mlx5-updates-2019-07-04-v2 > > Changes from last pull request: > Fixed comments from Jakub: > Patch 4: > - Replace zero memset with a call to memzero_explicit(). > Patch 11: > - Fix stats counters names. > - Drop TLS SKB with non-matching netdev. You guys probably really want to make 5.3 with this, so please feel free to follow up on the comments to patch 12 separately. Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
From: Tariq Toukan <tariqt@mellanox.com> Date: Fri, 5 Jul 2019 18:30:10 +0300 > This series from Eran and me, adds TLS TX HW offload support to > the mlx5 driver. Series applied, please deal with any further feedback you get from Jakub et al. Thanks.
On 7/6/2019 2:29 AM, David Miller wrote: > From: Tariq Toukan <tariqt@mellanox.com> > Date: Fri, 5 Jul 2019 18:30:10 +0300 > >> This series from Eran and me, adds TLS TX HW offload support to >> the mlx5 driver. > > Series applied, please deal with any further feedback you get from > Jakub et al. > > Thanks. > I will followup with patches addressing Jakub's feedback. Thanks, Tariq
On Sun, 7 Jul 2019 06:44:27 +0000, Tariq Toukan wrote: > On 7/6/2019 2:29 AM, David Miller wrote: > > From: Tariq Toukan <tariqt@mellanox.com> > > Date: Fri, 5 Jul 2019 18:30:10 +0300 > > > >> This series from Eran and me, adds TLS TX HW offload support to > >> the mlx5 driver. > > > > Series applied, please deal with any further feedback you get from > > Jakub et al. > > I will followup with patches addressing Jakub's feedback. Ping.
On 7/17/2019 8:41 PM, Jakub Kicinski wrote: > On Sun, 7 Jul 2019 06:44:27 +0000, Tariq Toukan wrote: >> On 7/6/2019 2:29 AM, David Miller wrote: >>> From: Tariq Toukan <tariqt@mellanox.com> >>> Date: Fri, 5 Jul 2019 18:30:10 +0300 >>> >>>> This series from Eran and me, adds TLS TX HW offload support to >>>> the mlx5 driver. >>> >>> Series applied, please deal with any further feedback you get from >>> Jakub et al. >> >> I will followup with patches addressing Jakub's feedback. > > Ping. > Hi Jakub, I'm waiting for the window to open: http://vger.kernel.org/~davem/net-next.html Do you think these can already go to net as fixes? Regards, Tariq
On Thu, 18 Jul 2019 07:40:22 +0000, Tariq Toukan wrote: > On 7/17/2019 8:41 PM, Jakub Kicinski wrote: > > On Sun, 7 Jul 2019 06:44:27 +0000, Tariq Toukan wrote: > >> On 7/6/2019 2:29 AM, David Miller wrote: > >>> From: Tariq Toukan <tariqt@mellanox.com> > >>> Date: Fri, 5 Jul 2019 18:30:10 +0300 > >>> > >>>> This series from Eran and me, adds TLS TX HW offload support to > >>>> the mlx5 driver. > >>> > >>> Series applied, please deal with any further feedback you get from > >>> Jakub et al. > >> > >> I will followup with patches addressing Jakub's feedback. > > > > Ping. > > > > Hi Jakub, > > I'm waiting for the window to open: > http://vger.kernel.org/~davem/net-next.html > > Do you think these can already go to net as fixes? Yes, certainly. It's documentation and renaming a stat before it makes it into an official release.
From: Jakub Kicinski <jakub.kicinski@netronome.com> Date: Thu, 18 Jul 2019 10:08:47 -0700 > Yes, certainly. It's documentation and renaming a stat before it makes > it into an official release. Agreed.
On 7/18/2019 10:09 PM, David Miller wrote: > From: Jakub Kicinski <jakub.kicinski@netronome.com> > Date: Thu, 18 Jul 2019 10:08:47 -0700 > >> Yes, certainly. It's documentation and renaming a stat before it makes >> it into an official release. > > Agreed. > Ack. I'll prepare and send this week. Tariq