mbox series

[net-next,v5,0/5] net: stmmac: enable EHL SGMI

Message ID 1559332694-6354-1-git-send-email-weifeng.voon@intel.com
Headers show
Series net: stmmac: enable EHL SGMI | expand

Message

Voon, Weifeng May 31, 2019, 7:58 p.m. UTC 
This patch-set is to enable Ethernet controller
(DW Ethernet QoS and DW Ethernet PCS) with SGMII interface in Elkhart Lake.
The DW Ethernet PCS is the Physical Coding Sublayer that is between Ethernet
MAC and PHY and uses MDIO Clause-45 as Communication.

Kweh Hock Leong (1):
  net: stmmac: enable clause 45 mdio support

Ong Boon Leong (3):
  net: stmmac: introducing support for DWC xPCS logics
  net: stmmac: add xpcs function hooks into main driver and ethtool
  net: stmmac: add xPCS functions for device with DWMACv5.1

Voon Weifeng (1):
  net: stmmac: add EHL SGMII 1Gbps PCI info and PCI ID

 drivers/net/ethernet/stmicro/stmmac/Makefile       |   2 +-
 drivers/net/ethernet/stmicro/stmmac/common.h       |   1 +
 drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c  |  33 ++++
 drivers/net/ethernet/stmicro/stmmac/dwxpcs.c       | 198 +++++++++++++++++++++
 drivers/net/ethernet/stmicro/stmmac/dwxpcs.h       |  51 ++++++
 drivers/net/ethernet/stmicro/stmmac/hwif.c         |  42 ++++-
 drivers/net/ethernet/stmicro/stmmac/hwif.h         |  21 +++
 drivers/net/ethernet/stmicro/stmmac/stmmac.h       |   2 +
 .../net/ethernet/stmicro/stmmac/stmmac_ethtool.c   |  50 ++++--
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c  | 140 +++++++++++----
 drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c  |  40 ++++-
 drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c   | 111 ++++++++++++
 include/linux/phy.h                                |   2 +
 include/linux/stmmac.h                             |   3 +
 14 files changed, 638 insertions(+), 58 deletions(-)
 create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwxpcs.c
 create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwxpcs.h

Comments

Jose Abreu June 3, 2019, 11:54 a.m. UTC | #1 
From: Voon Weifeng <weifeng.voon@intel.com>

> This patch-set is to enable Ethernet controller
> (DW Ethernet QoS and DW Ethernet PCS) with SGMII interface in Elkhart Lake.
> The DW Ethernet PCS is the Physical Coding Sublayer that is between Ethernet
> MAC and PHY and uses MDIO Clause-45 as Communication.

This series look fine to me but unfortunately I don't have my GMAC5.10 
setup available to test for regressions ... The changes look isolated 
though.

Could you please run the stmmac selftests at least and add the output 
here ?

Thanks,
Jose Miguel Abreu
Voon, Weifeng June 4, 2019, 10:44 a.m. UTC | #2 
> > This patch-set is to enable Ethernet controller (DW Ethernet QoS and
> > DW Ethernet PCS) with SGMII interface in Elkhart Lake.
> > The DW Ethernet PCS is the Physical Coding Sublayer that is between
> > Ethernet MAC and PHY and uses MDIO Clause-45 as Communication.
> 
> This series look fine to me but unfortunately I don't have my GMAC5.10
> setup available to test for regressions ... The changes look isolated
> though.
> 
> Could you please run the stmmac selftests at least and add the output
> here ?

Sure, the selftests feature is good as I am able to detect that the 
dwmac510_xpcs_ops misses the selftest entry. I will fix and add the
selftests results in the v6 cover letter. 


> 
> Thanks,
> Jose Miguel Abreu