| Message ID | 1544042985-25347-1-git-send-email-andrew@lunn.ch |
|---|---|
| Headers | show |
| Series | u32 to linkmode fixes | expand |
From: Andrew Lunn <andrew@lunn.ch> Date: Wed, 5 Dec 2018 21:49:39 +0100 > This patchset fixes issues found in the last patchset which converted > the phydev advertise etc, from a u32 to a linux bitmap. Most of the > issues are the result of clearing bits which should not of been > cleared. To make the API clearer, the idea from Heiner Kallweit was > used, with _mod_ to indicate the function modifies just the bits it > needs to, or _to_ to clear all bits and just set bit that need to be > set. Series applied, thanks Andrew. Please always list the Fixes tag first in the future. I fixed if up for you this time. Thanks again.
This patchset fixes issues found in the last patchset which converted the phydev advertise etc, from a u32 to a linux bitmap. Most of the issues are the result of clearing bits which should not of been cleared. To make the API clearer, the idea from Heiner Kallweit was used, with _mod_ to indicate the function modifies just the bits it needs to, or _to_ to clear all bits and just set bit that need to be set. Andrew Lunn (6): net: mii: Fix autoneg in mii_lpa_to_linkmode_lpa_t() net: mii: Rename mii_stat1000_to_linkmode_lpa_t phy: marvell: Rename mii_lpa_to_linkmode_lpa_t net: mii: Add mii_lpa_mod_linkmode_lpa_t net: mii: mii_lpa_mod_linkmode_lpa_t: Make use of linkmode_mod_bit helper net: phy: Fix ioctl handler when modifing MII_ADVERTISE drivers/net/phy/marvell.c | 24 +++++----- drivers/net/phy/marvell10g.c | 2 +- drivers/net/phy/phy.c | 4 +- drivers/net/phy/phy_device.c | 6 +-- include/linux/linkmode.h | 9 ++++ include/linux/mii.h | 93 +++++++++++++++++++++++++----------- 6 files changed, 91 insertions(+), 47 deletions(-)